Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(conventionalcommmits practice): change used library #197

Merged
merged 1 commit into from
Jan 8, 2020
Merged

fix(conventionalcommmits practice): change used library #197

merged 1 commit into from
Jan 8, 2020

Conversation

prokopsimek
Copy link
Member

No description provided.

@prokopsimek prokopsimek self-assigned this Jan 8, 2020
@prokopsimek
Copy link
Member Author

prokopsimek commented Jan 8, 2020 •
edited
Loading

DX Scanner Report DXScanner.io

https://github.com/DXHeroes/dx-scanner

⚠️ Improvements with medium impact

Solve Pull Requests Continuously

Do not have an open Pull Request more than 30 days. Review PRs continuously. https://dxkb.io/p/pull-requests

Update Dependencies of Minor and Patch Level

Keep the dependencies updated to eliminate security concerns and compatibility issues. Use, for example, npm-check-updates. https://github.com/tjunnone/npm-check-updates

Name New Current
@types/node 13.1.4 12.12.24
nock 11.7.2 11.7.1

Impact changed from high to medium.

ESLint Without Errors

Use the ESLint correctly. You have some errors. https://eslint.org/

🔔 Improvements with minor impact

Write Commit Messages by Convention

https://www.conventionalcommits.org/

Commit Message Problems
fix(CIReporter): load all comments instead of just a first page [object Object]
Update src/inspectors/common/Paginated.ts [object Object] 
                                                                                                                                                 | [object Object]

Co-Authored-By: Prokop Simek prokopsimek@users.noreply.github.com |
Update src/inspectors/common/Paginated.ts | [object Object]
| [object Object]
Co-Authored-By: Prokop Simek prokopsimek@users.noreply.github.com |
test: WIP write test for getting max number of PRs | [object Object]
feat(CIReportBuilder): add PR msg builder and change a structure | [object Object]
feat(CIReportBuilder): add PR msg builder and change a structure | [object Object]
feat(GHActions): publish GH Marketplace Docker image with DX Scanner | [object Object]
fix(CIReporter): await all reporters | [object Object]
Add linesAdded and linesRemoved to own interface of Commit (#184) | [object Object]
| [object Object]
Add linesAdded and linesRemoved to own interface of Commit |
refactor: use options so it's not necessary to follow the order of values. | [object Object]
| [object Object]
refactor: use options so it's not necessary to follow the order of values. | [object Object]
| [object Object]
refactor: use options so it's not necessary to follow the order of values. | [object Object]
| [object Object]
fix: Add comments | [object Object]
feat(CIReporter): add CI reporter | [object Object]
feat: allow to get one specific pull request with diffStat in GithubService and BitbucketService | [object Object]
feat: add getPullsDiffStat() in CollaborationInspector; allow to get one specific pull request with diffStat | [object Object]
test: add test for getting pullrequests with diffStat if withDiffStat value is true | [object Object]
feat: implement getPullsDiffStat() in BitbucketService and add test for that | [object Object]
fix: remove unnecessary Promise.all(); remove request for getting diffStat | [object Object]
fix: add linesAdded and linesRemoved to own interface of Commit. Implement it in BitbucketService and rewrite tests. | [object Object]
| [object Object]
Feature/time to solve practice (#182) | [object Object]
| [object Object]
Feature/time to solve practice |
fix: rebind IContentRepositoryBrowser in practice instead of binding in inversify.config.ts | [object Object]
fix: rename practice and files. Add name and suggestion text. | [object Object]
fix: use arguments provider uri to detect if bind GithubService or BitbucketService | [object Object]
chore(ConfigProvider): move to more relevant Scanner folder | [object Object]
fix: as the bitbucket fails if the account is a team account add possibility to ownerId be a null | [object Object]
feat(CLIReporter): add rich suggestion text to the report | [object Object]
Fix/Bitbucket mergedAt, closedAt values (#176) | [object Object]
| [object Object]
Fix/Bitbucket mergedAt, closedAt values |
Feature/bitbucket filter (#164) | [object Object]
| [object Object]
Feature/bitbucket filter |
feat(CLIReporter): show detailed info (collected data) from practices | [object Object]
Update src/services/bitbucket/BitbucketService.ts | [object Object]
| [object Object]
fix: use better syntax |
|
Co-Authored-By: Prokop Simek prokopsimek@users.noreply.github.com |
fix: use axios because bitbucket client can't allow to get all pullrequests. Write tests for that. | [object Object]
| [object Object]
fix: Add parse-commit-message | [object Object]
Issue #73 feat(cli): --init command creates a yaml config file (#167) | [object Object]
| [object Object]
Issue #73 feat(cli): --init command creates a yaml config file |
added a test for Scanner.ts | [object Object]
| [object Object]
added jest tests for init configurator | [object Object]
| [object Object]
fix(practices): unify impact and defaultImpact to impact and overridenImpact | [object Object]
feature: implement getCommit() | [object Object]
feature: add new practice - correct commit message | [object Object]
fix(cli): using sync method to write files & practices are sorted alphabetically | [object Object]
WIP: fix listing all PRs | [object Object]
| [object Object]
Update test/helpers/bitbucketNock.ts | [object Object]
| [object Object]
Update src/services/git/CSVServicesUtils.ts | [object Object]
| [object Object]
Co-Authored-By: Prokop Simek prokopsimek@users.noreply.github.com |
Update src/services/git/CSVServicesUtils.ts | [object Object]
| [object Object]
Co-Authored-By: Prokop Simek prokopsimek@users.noreply.github.com |
Update src/services/bitbucket/BitbucketService.ts | [object Object]
| [object Object]
Co-Authored-By: Prokop Simek prokopsimek@users.noreply.github.com |
Update src/services/bitbucket/BitbucketService.ts | [object Object]
| [object Object]
Co-Authored-By: Prokop Simek prokopsimek@users.noreply.github.com |
Update src/model.ts | [object Object]
| [object Object]
Co-Authored-By: Prokop Simek prokopsimek@users.noreply.github.com |
removed a console.log and removed export for createYAML | [object Object]
| [object Object]
fix: via #165 (comment) | [object Object]
fix: use own definition of PR -> implement getPRState() to get the state specific for services | [object Object]
test: add test for testing when there is a PR, but older than 30 days than the last commit in master | [object Object]
feature: add possibility to define createdAt and updatedAt date | [object Object]
fix: if the PR is updated, count with that date, not with the createdAt date | [object Object]
Update src/contexts/practice/PracticeContext.ts | [object Object]
| [object Object]
fix: move inspectors to language component context instead of overall container | [object Object]
Update src/practices/LanguageIndependent/DoesPullRequests.ts | [object Object]
| [object Object]
Co-Authored-By: Prokop Simek prokopsimek@users.noreply.github.com |
Feature/split updated dependencies practice (#162) | [object Object]
| [object Object]
Feature/split updated dependencies practice |
Update src/practices/LanguageIndependent/DoesPullRequests.ts | [object Object]
| [object Object]
Co-Authored-By: Prokop Simek prokopsimek@users.noreply.github.com |
Update src/services/bitbucket/BitbucketService.spec.ts | [object Object]
| [object Object]
WIP: testing | [object Object]
| [object Object]
feat: Detect parcticing/notPracticing based on date of commit and date of PR minus 30 days | [object Object]
| [object Object]
WIP: implement Does PullRequest practice | [object Object]
| [object Object]
fix: return CollaborationInspector and IssueTrackingInspector (not undefined), | [object Object]
WIP: return list of commits in own interface | [object Object]
| [object Object]
Update src/practices/JavaScript/DependenciesVersionMajorLevel.ts | [object Object]
| [object Object]
Co-Authored-By: Prokop Simek prokopsimek@users.noreply.github.com |
Update src/practices/JavaScript/DependenciesVersionMinorPatchLevel.ts | [object Object]
| [object Object]
Co-Authored-By: Prokop Simek prokopsimek@users.noreply.github.com |
Update src/practices/JavaScript/DependenciesVersionMinorPatchLevel.spec.ts | [object Object]
| [object Object]
Co-Authored-By: Prokop Simek prokopsimek@users.noreply.github.com | [object Object]
fix: add BitbucketPullRequestState because of CollaborationInspector to the options | [object Object]
feat(fileInspector): file inspector with root base path to scan files in whole root folder | [object Object]
| [object Object]
Update src/practices/JavaScript/DependenciesVersionMajorLevel.ts | [object Object]
| [object Object]
fix(configuration): customized practices are not coumputed to the final DX Score now | [object Object]
feat: add Update Dependencies With Minor or Patch Level practice and tests for that | [object Object]
feat: change practice 'Update Dependencies' to 'Update Dependencies with Major Level' | [object Object]
fix(configuration): customized practices are not coumputed to the final DX Score now | [object Object]
chore(renovatebot): configure updates weekly & group major an patch updates to one branch | [object Object]
feat(cli): do not require -a argument, accept env variable DX_GIT_SERVICE_TOKEN | [object Object]
Hotfix/deprecated tslint (#151) | [object Object]
| [object Object]
Hotfix/deprecated tslint |
Chore/msg components below report (#150) | [object Object]
| [object Object]
Chore/msg components below report |
fix: Log msg about number of components under report. | [object Object]
| [object Object]
fix: Name of practice. | [object Object]
| [object Object]
fixed index and README to specify failure mode | [object Object]
| [object Object]
Merged master & resolved conflicts #3 | [object Object]
| [object Object]
Update src/inspectors/package/JavaPackageInspector.ts | [object Object]
| [object Object]
Activated dependsOn DX Practice | [object Object]
| [object Object]
Merges master to java_detector & resolved conflicts #2 | [object Object]
| [object Object]
fix(CLIReporter): remove brackets after links | [object Object]
|

  • it brokes link (added ")" at the end of url) |
    fix(CLI auth): prompt Bitbucket credentials only if a path is bbucket url | [object Object]
    | [object Object]
    Merged updated java_detector to java_practices & resolved conflicts | [object Object]
    | [object Object]
    reversing javascript.ts deletion to pass Travis | [object Object]
    | [object Object]
    refactored JavaPackageInspector | [object Object]
    | [object Object]
    Merged master to java_detector & resolved conflicts | [object Object]
    | [object Object]
    removed JavaGitignoreIsPresent | [object Object]
    | [object Object]
    Improved gitignore practice for Java & Maven & Gradle | [object Object]
    | [object Object]
    Correctly set practices for maven and gradle and listed index | [object Object]
    | [object Object]
    fixed typo | [object Object]
    | [object Object]
    Gitignore is present practice for Java | [object Object]
    | [object Object]
    Readme update | [object Object]
    | [object Object]
    Practices - Updates | [object Object]
    | [object Object]
    fix(JS Practices): mark as notPracticing if not exists scripts in package.json | [object Object]
    | [object Object]
    fix(FileInspector): do not throw error if scanning for a files in subfolders | [object Object]
    | [object Object]
    fix(CIUsedPractice): respect config filed for Azure and Circle CI | [object Object]
    ci(scanner): DX SCanner in a pipeline to guard a good DX! | [object Object]
    ci(scanner): DX SCanner in a pipeline to guard a good DX! | [object Object]
    doc: remove unnecessary text | [object Object]
    doc: Rename title | [object Object]
    | [object Object]
    doc: Copy paste --help | [object Object]
    | [object Object]
    chore(CLI): add examples and enhance some help texts | [object Object]
    chore(CLI): add examples and enhance some help texts | [object Object]
    doc: Add Flags Usage and Score Counting section into Readme | [object Object]
    | [object Object]
    chore(lint) | [object Object]
    | [object Object]
    feat(CLI): add default value of fail | [object Object]
    Update src/index.ts | [object Object]
    | [object Object]
    Co-Authored-By: Prokop Simek prokopsimek@users.noreply.github.com |
    doc: add documentation to the method. | [object Object]
    | [object Object]
    Update src/scanner/ScannerUtils.ts | [object Object]
    | [object Object]
    Co-Authored-By: Prokop Simek prokopsimek@users.noreply.github.com |
    Update src/scanner/Scanner.ts | [object Object]
    | [object Object]
    Co-Authored-By: Prokop Simek prokopsimek@users.noreply.github.com |
    Update src/scanner/Scanner.ts | [object Object]
    | [object Object]
    Co-Authored-By: Prokop Simek prokopsimek@users.noreply.github.com |
    Update src/scanner/Scanner.ts | [object Object]
    | [object Object]
    Co-Authored-By: Prokop Simek prokopsimek@users.noreply.github.com |
    Update src/scanner/Scanner.ts | [object Object]
    | [object Object]
    Co-Authored-By: Prokop Simek prokopsimek@users.noreply.github.com |
    Update src/index.ts | [object Object]
    | [object Object]
    Co-Authored-By: Prokop Simek prokopsimek@users.noreply.github.com |
    Update src/index.ts | [object Object]
    | [object Object]
    Co-Authored-By: Prokop Simek prokopsimek@users.noreply.github.com |
    WIP: tests for fail after report | [object Object]
    | [object Object]
    feat(CI failure): fail on recursive impacts | [object Object]
    WIP: fix the condition | [object Object]
    | [object Object]
    Update src/scanner/Scanner.ts | [object Object]
    | [object Object]
    Co-Authored-By: Prokop Simek prokopsimek@users.noreply.github.com |
    Update src/inversify.config.ts | [object Object]
    | [object Object]
    Co-Authored-By: Prokop Simek prokopsimek@users.noreply.github.com |
    fix: Refactor code using .filter() method. | [object Object]
    | [object Object]
    feature: fail (exit code 1) after report if there are not practicing practices and user uses fail flag. | [object Object]
    | [object Object]
    | [object Object]
    fix(practice): upgrade ncu to new version with fixed process.on in for loop | [object Object]
    Chore/read yaml eslintconfig (Chore/read yaml eslintconfig #98) | [object Object]
    | [object Object]
    Chore/read yaml eslintconfig |
    fix: Add PracticeImpact types | [object Object]
    Update src/contexts/ConfigProvider.ts | [object Object]
    | [object Object]
    Co-Authored-By: Prokop Simek prokopsimek@users.noreply.github.com |
    fix: Showing error message in debug mode. | [object Object]
    | [object Object]
    test: Add tests for EslintWithoutErrorsPractice; | body must have leading blank line
    | [object Object]
    fix: remove unnecessary try catch; |
    fix(CIUsedPractice): detect Appveyor CI | [object Object]
    fix(CLI): remove experimental warnings with Unix compatibility | [object Object]
    fix(CLIReport): off and failed practices read from component instead of all | [object Object]
    | [object Object]
    feat(CLI): remove experimental warnings | [object Object]
    fix: Remove unnecessary comments. | [object Object]
    | [object Object]
    fix(dockerization): correctly detect library component instead of application | [object Object]
    fix: Loading yaml .eslintrc file | [object Object]
    fix: name of PullRequestState and IssueState, which is used just by GitHub for now | [object Object]
    JavaPackageInspector cleanup | [object Object]
    | [object Object]
    Update src/services/bitbucket/BitbucketService.ts | [object Object]
    | [object Object]
    Update src/services/bitbucket/BitbucketService.ts | [object Object]
    | [object Object]
    Update src/services/bitbucket/BitbucketService.ts | [object Object]
    | [object Object]
    fix: Show the right message to the user accordingt to used CVS. | [object Object]
    | [object Object]
    fix? formatting | [object Object]
    | [object Object]
    fix: Not passing build https://travis-ci.org/DXHeroes/dx-scanner/jobs/600727699 | [object Object]
    | [object Object]
    fix: Split mock response into files | [object Object]
    fix: allow only type string of userId. Fix returning UserInfo. | [object Object]
    cleaned up code | [object Object]
    | [object Object]
    Added test suites for ComponentDetector and PackageInspector | [object Object]
    | [object Object]
    mock files for JavaDetector | [object Object]
    | [object Object]
    fixes after code review and inspector optimisation | [object Object]
    | [object Object]
    add TODO "label" to values which the Bitbucket API doesn't have in response so we don't forgot to figure out how to get the values | [object Object]
    | [object Object]
    | [object Object]
    feat(CLI): add scan duration time | [object Object]
    feat(FileInspector): add cache to all methods | [object Object]
    WIP: resolve merge conflicts and fix test | [object Object]
    | [object Object]
    feature/bbucket intergration advanced types (feature/bbucket intergration advanced types #87) | [object Object]
    | [object Object]
    feature/bbucket intergration advanced types |
    WIP: fixing getting values | [object Object]
    | [object Object]
    fix: Facelift of the tests | [object Object]
    WIP: all tests fot BitbucketService are working, they just need a facelift | [object Object]
    | [object Object]
    | [object Object]
    WIP: fix test for getPullCommits() | [object Object]
    | [object Object]
    WIP: tests for getting PullRequests and one PullRequest are already working. | [object Object]
    | [object Object]
    | [object Object]
    | [object Object]
    fix: Bitbucket doesn't return time of closing, so the value will be undefined | [object Object]
    | [object Object]
    WIP: bitbucketNock | [object Object]
    | [object Object]
    WIP: writing tests. It call bitbucket API life now. | [object Object]
    | [object Object]
    | [object Object]
    Language detector for Python | [object Object]
    | [object Object]
    WIP: throw error, | body must have leading blank line
    | [object Object]
    fix: interface of PullRequest | [object Object]
    Feature: run eslint practice (Feature: run eslint practice #53) | [object Object]
    | [object Object]
    Feature: run eslint practice |
    fix: rename EslintConfig to PracticeConfig; return always PracticeConfig in getOverridenPractice() | [object Object]
    fix: allow user to customize configuration of DX scanner so it could be string or object | [object Object]
    Force isGlobal to notify option | [object Object]
    | [object Object]
    Use oclif's pjson instead of pjson package | [object Object]
    | [object Object]
    WIP: BitbucketIntegration | [object Object]
    | [object Object]
    | [object Object]
    feat(cli): add postinstall message with hint to create .dxscannerrc config file | [object Object]
    Hopefully this will also work on Windows | [object Object]
    | [object Object]
    No need to run anything when working on this package | [object Object]
    | [object Object]
    We now run different commands depending on the current package name | [object Object]
    | [object Object]
    Added postinstall in package.json | [object Object]
    | [object Object]
    fix(GitService): change join for resolve (fix(GitService): change join for resolve #74) | [object Object]
    Update README.md | [object Object]
    | [object Object]
    fixing import duplications | [object Object]
    | [object Object]
    Adding support for Gradle dependencies in Package Inspector | [object Object]
    | [object Object]
    BuildGradle interface | [object Object]
    | [object Object]
    re-working package inspector & adding g2js | [object Object]
    | [object Object]
    Chore: fix display remote url and split CLI report for components (Chore: fix display remote url and split CLI report for components #52) | [object Object]
    | [object Object]
  • WIP: Fix display remote url. The reasons was the JavaScriptComponentDetector, that was fixed. Trying to figure out how to add path for component. |
    |
  • WIP: Display split report for each component. |
    |
  • report: show split CLI report for each component |
    |
  • fix: saving ProjectComponentPlatform and tests for JavaScriptComponentDetector. |
    |
  • fix: show the local path even if the repositoryPath is present |
    |
  • fix: path in reports |
    |
  • fix: Reflect every package - use regex |
    |
  • Fix: allow regex in hasPackage() because of EslintUsedPractice |
    |
  • fix: remove dx-scanner package |
    Chore/update dependencies (Chore/update dependencies #55) | [object Object]
    | [object Object]
  • chore: update nock typings |
    |
  • chore: update renovate config |
    WIP: Tests for Bitbucket | [object Object]
    | [object Object]
    | [object Object]
    Readme Updates (Readme Updates #54) | [object Object]
    | [object Object]
    WIP: tests for BitbucketService | [object Object]
    | [object Object]
    fix: Name of issueNumber | [object Object]
    WIP: Write tests for Bitbucket Service | [object Object]
    | [object Object]
    | [object Object]
    WIP: implement Bitbucket Service | [object Object]
    | [object Object]
    interface for pom.xml parser | [object Object]
    | [object Object]
    fix: Path for scanFor() | [object Object]
    fix: Catch the error and if it's SyntaxError return PracticeEvaluationResult.unknown | [object Object]
    | [object Object]
    fix: Fix the condition for eslintIgnore | [object Object]
    fix: Remove console.logs, | body must have leading blank line
    | [object Object]
    fix: catch the error if there CLI cannot find a module - return PracticeEvalutionResult.unknown |
    WIP: Implementing BitbucketService | [object Object]
    | [object Object]
    | [object Object]
    feat: add isBitbucketPath() to check if the path is from Bitbucket. | [object Object]
    fix: Remove unnecessary logs. | [object Object]
    | [object Object]
    fix: Allow user to add impact in object in dx config file | [object Object]
    fix: Interface of Config; add interface for EslintConfig and use it in PracticeContext | [object Object]
    | [object Object]
    WIP: run eslint programatically | [object Object]
    | [object Object]
    added an XML parser, returning component detector | [object Object]
    | [object Object]
    code cleanup | [object Object]
    | [object Object]
    init component detector & package inspector | [object Object]
    | [object Object]
    removing a console log | [object Object]
    | [object Object]
    added a spec test for Java detector | [object Object]
    | [object Object]
    detecting Java as a language | [object Object]
    | [object Object]
    fixing gradle extension | [object Object]
    | [object Object]
    WIP: Run ESLint programatically | [object Object]
    | [object Object]
    | [object Object]
    distinguishing Gradle and Maven projects | [object Object]
    | [object Object]
    init: Java Language Detector class | [object Object]
    | [object Object]
    Update Node.js to v10.16.3 | [object Object]
    | [object Object]
    Feature: Possibility to override config (Feature: Possibility to override config #45) | [object Object]
    | [object Object]
  • fix: Catch the ServiceError so it is possible catch the TypeError (etc). | [object Object]
    |
  • feat: Implement ConfigProvider to allow user to add config file to switch off some practices via name. |
    |
  • feat: Bind the ConfigProvider. |
    |
  • feat: implement ConfigProvider into Scanner. |
    |
  • feat: Allow user to setup yaml config. |
    |
  • WIP: ConfigProvider |
    |
  • chore: add some architecture hints |
    |
  • WIP: CongiProvider binding |
    |
  • chore: fix config provider |
    |
  • fix: Make the ConfigProvider work. |
    |
  • WIP: try to save the default impact |
    |
  • feat: Report the changed impact in CLI Reporter. |
    |
  • fix: unnecessary async in JSONReport |
    |
  • feat: add off type to PracticeImpact, |
    fix: rename offedPractices to practicesOff |
    |
  • feat: Show deep JSON report. |
    |
  • fix: refactor if else to ternary operator, change showHidden to false |
    |
  • WIP: add config interface |
    |
  • feat: add PracticeImpactType |
    |
  • fix: Use the id of practice for switching off tha preacitces in config |
    |
  • feat: Add info about config file in README.md |
    |
  • Update README.md |
    |
    Co-Authored-By: Prokop Simek prokopsimek@users.noreply.github.com |
    |
  • Update src/contexts/projectComponent/projectComponentContextBinding.ts |
    |
    Co-Authored-By: Prokop Simek prokopsimek@users.noreply.github.com |
    |
  • Update src/scanner/Scanner.ts |
    |
    Co-Authored-By: Prokop Simek prokopsimek@users.noreply.github.com |
    |
  • fix: Show practices switched off in report, |
    fix: Use enum PracticeImpact instead of new type PracticeImpactType, |
    fix: add defaultImpact in decorator. |
    |
  • refactor: Split the detectPractices() -> implement filterPractices() in ScannerUtils |
    |
  • refactor: Add filtering just name from metadata to filterPractices() |
    |
  • refactor: Passing practicesOff |
    |
  • test: Add test for filterPractices() |
    |
  • Update src/index.ts |
    |
  • fix: remove unnecessary code |
    |
  • fix: Change colour of output if no practice was switched off |
    fix: add new practicesWitchContext for every component in for loop. (fix: add new practicesWitchContext for every component in for loop. #46) | [object Object]
    |
  • fix: add new practicesWitchContext for every component in for loop. |
    |
  • Update src/scanner/Scanner.ts |
    |
  • Update src/scanner/Scanner.ts |
    WIP: Run eslint programatically. | [object Object]
    | [object Object]
    | [object Object]
    | [object Object]
    fix: Remove reporting in the new file. | [object Object]
    | [object Object]
    feat: Write JSON report to the new file. | [object Object]
    | [object Object]
    feat: Add possibility to have an output in JSON. | [object Object]
    | [object Object]
    feat: Add JSON Reporter. | [object Object]
    | [object Object]
    fix: Improve the reporter interface. | [object Object]
    | [object Object]
    fix: Improve the JSONReport. | [object Object]
    | [object Object]
    Move caching from Git to GitHubService | [object Object]
    | [object Object]
    Feat: Add possibility to run scanner on a private repository (Feat: Add possibility to run scanner on a private repository #42) | [object Object]
    | [object Object]
    Feat: Add possibility to run scanner on a private repository | [object Object]
    WIP: implement JSON reporter | [object Object]
    | [object Object]
    cli: add json flag | [object Object]
    WIP(reporter): Add draft of JSON reporter interface. | [object Object]
    | [object Object]
    | [object Object]
    | [object Object]
    fix: Remove unnecessary import | [object Object]
    fix: Logic with accessType and tests for private repo. | [object Object]
    | [object Object]
    fix: Tests for private repos. | [object Object]
    | [object Object]
    Use GitHubService instead of GitHubClient in Git | [object Object]
    | [object Object]
    Make GitHubService.getPullRequests able to return closed pulls | [object Object]
    | [object Object]
    fix: Catch the auth error and handle it in index.ts instead of ScanningStrategyDetector | [object Object]
    | [object Object]
    Make GitHubService.getRepoContent return directories | [object Object]
    | [object Object]
    Make GitHubService.getRepoContent return symlink target | [object Object]
    | [object Object]
    Use GitHubService instead of GitHubClient in ScanningStrategyDetector | [object Object]
    | [object Object]
    Add GitHubService.getRepo | [object Object]
    | [object Object]
    WIP: try to fix tests for private repo | [object Object]
    | [object Object]
    WIP: try to fix tests for private repo | [object Object]
    | [object Object]
    feat(cli): add possibility to insert AT after running scanner if the AT was not provided. | [object Object]
    | [object Object]
    fix: Remove nonsense condition. | [object Object]
    | [object Object]
    fix: Remove unused import. | [object Object]
    | [object Object]
    fix: Remove unused variable. | [object Object]
    | [object Object]
    fix: Remove unused interface. | [object Object]
    | [object Object]
    fix: Remove unnecessary piece of code | [object Object]
    fix: Remove unused interface. | [object Object]
    | [object Object]
    fix(cli): Remove console.log when a 404 error happens. Use debug() instead. | [object Object]
    | [object Object]
    | [object Object]
    WIP(privateRepo): get auth from cli and pass it to the createRootContainer() | [object Object]
    | [object Object]
    | [object Object]
    | [object Object]
    Make Git implement IProjectFilesBrowserService | [object Object]
    | [object Object]
    Reduce IProjectFilesBrowserService to readonly methods | [object Object]
    | [object Object]
    feat(CI): add scripts to run on travis (feat(CI): add scripts to run on travis #39) | [object Object]
    |
  • feat(CI): add scripts to run on travis, add condition to deploy if linux build passes. |
    |
  • fix(CI): allow failure on windows |
    |
  • Update .travis.yml |
    |
    Co-Authored-By: Prokop Simek prokopsimek@users.noreply.github.com |
    Add Git.flatTraverse | [object Object]
    | [object Object]
    Add Git.isDirectory | [object Object]
    | [object Object]
    chore: Change suggestion text as we've started to use Renovate Bot instead of GreenKeeper. | [object Object]
    | [object Object]
    | [object Object]
    Add Git.isFile | [object Object]
    | [object Object]
    Make GitHubNock.getPull reuse the repository | [object Object]
    | [object Object]
    Make GitHubNock.getPulls reuse the repository | [object Object]
    | [object Object]
    Change Git.getTextFileContent to Git.readFile | [object Object]
    | [object Object]
    Remove Git.getFile | [object Object]
    | [object Object]
    Change Git.listDirectory to Git.readDirectory | [object Object]
    | [object Object]
    Add Git.getMetadata | [object Object]
    | [object Object]
    Make Git.spec.ts more similar to FileSystemService tests | [object Object]
    | [object Object]
    Add PullRequest | [object Object]
    | [object Object]
    Test Git.getPullRequestCount | [object Object]
    | [object Object]
    Add PullRequestItem | [object Object]
    | [object Object]
    Add BranchItem | [object Object]
    | [object Object]
    Add Repository | [object Object]
    | [object Object]
    Add UserItem | [object Object]
    | [object Object]
    Test Git.getContributorCount | [object Object]
    | [object Object]
    Add GitHubNock.getContributors | [object Object]
    | [object Object]
    Test Git.getTextFileContent | [object Object]
    | [object Object]
    Test Git.getFile | [object Object]
    | [object Object]
    Test Git.listDirectory | [object Object]
    | [object Object]
    Add a Git.exists method | [object Object]
    | [object Object]
    Make GitHubNock able to persist interceptions optionally | [object Object]
    | [object Object]
    Add GitHubNock.getNonexistentContents | [object Object]
    | [object Object]
    Add GitHubNock.getDirectory | [object Object]
    | [object Object]
    Add GitHubNock.getSymlink | [object Object]
    | [object Object]
    Add GitHubNock.getFile | [object Object]
    | [object Object]
    Add GitHubNock | [object Object]
    | [object Object]
    Add a Git.getRepoContent method | [object Object]
    | [object Object]
    chore: configure renovate bot to not use pinned versions and allow too auto-merge if not major version change | [object Object]
    chore: configure renovate bot to not use pinned versions and allow too auto-merge if not major version change | [object Object]
    fix(README): fix command for installing (fix(README): fix command for installing #29) | [object Object]
    |
  • fix(README): fix command for installing, |
    fix: name of contributor |
    feat: add aliases to readme, |
    |
  • fix(README): change the name of command, |
    fix: discard the change of displaying name as it should be generated automatically by .all-contributorsrc |
    Update @typescript-eslint/eslint-plugin to the latest version 🚀 (Update @typescript-eslint/eslint-plugin to the latest version 🚀 #24) | [object Object]
    | [object Object]
  • ci(multiOS): add windows, osx and linux as matrix for Travis CI |
    |
  • fix(FileSystemService): readDirectory for symlinks on win32 |
    |
  • ci(config): remove osx pipeline |
    |
  • refactor(FileSystems): remove support for symbolic links |
    |
  • refactor(FileSystems): remove support for symbolic links |
    |
  • fix(FileSystem): win32 os fixed |
    |
  • fix(FileSystem): support win32 arch |
    |
  • fix(FileSystem): support win32 arch |
    |
  • fix(FileSystem): support win32 arch |
    |
  • refactor(VirtualFileSystemService): use memfs instead of own implementation |
    |
  • fixes win support |
    |
  • fix(FileSystem): support win32 arch |
    |
  • fix: all FS tests on OSX |
    |
  • refactor(sharedSubpath): renamed variables and added comment, fixed specs |
    |
  • ci: restrict OS jobs just for pull requests |
    |
  • fix: set separator based on OS |
    |
  • chore(package): update @typescript-eslint/eslint-plugin to version 2.0.0 |
    |
  • test: review notes resolved |
    |
  • refactor(VirtualFileSystemService): removed duplicated logic with FileSystemService |
    |
  • refactor(FileSystemService): removed VFSS and renamed files to FSS |
    |
  • refactor(FileSystemService): removed VFSS and renamed files to FSS |
    |
  • fix windows |
    |
  • fix(eslint): Fix errors caused by new major version of eslint-plugin. |
    |
  • fix windows |
    |
  • fix(eslint): Switch the @typescript-eslint/consistent-type-assertions off. |
    |
  • fix windows |
    |
  • refactor(FileSystemService): removed VFSS and renamed files to FSS |
    |
  • ci: do not verify gpg |
    |
  • fix(eslint-plugin): Fix 'prefer-const' errors. |
    Update @typescript-eslint/parser to the latest version 🚀 (Update @typescript-eslint/parser to the latest version 🚀 #25) | [object Object]
    | [object Object]
  • ci(multiOS): add windows, osx and linux as matrix for Travis CI |
    |
  • fix(FileSystemService): readDirectory for symlinks on win32 |
    |
  • ci(config): remove osx pipeline |
    |
  • refactor(FileSystems): remove support for symbolic links |
    |
  • refactor(FileSystems): remove support for symbolic links |
    |
  • fix(FileSystem): win32 os fixed |
    |
  • fix(FileSystem): support win32 arch |
    |
  • fix(FileSystem): support win32 arch |
    |
  • fix(FileSystem): support win32 arch |
    |
  • refactor(VirtualFileSystemService): use memfs instead of own implementation |
    |
  • fixes win support |
    |
  • fix(FileSystem): support win32 arch |
    |
  • fix: all FS tests on OSX |
    |
  • refactor(sharedSubpath): renamed variables and added comment, fixed specs |
    |
  • ci: restrict OS jobs just for pull requests |
    |
  • fix: set separator based on OS |
    |
  • chore(package): update @typescript-eslint/parser to version 2.0.0 |
    |
  • test: review notes resolved |
    |
  • refactor(VirtualFileSystemService): removed duplicated logic with FileSystemService |
    |
  • refactor(FileSystemService): removed VFSS and renamed files to FSS |
    |
  • refactor(FileSystemService): removed VFSS and renamed files to FSS |
    |
  • fix windows |
    |
  • fix windows |
    |
  • fix windows |
    |
  • refactor(FileSystemService): removed VFSS and renamed files to FSS |
    |
  • ci: do not verify gpg |
    |
  • feat(eslint): install eslint-parser |
    Feat(toposort): Remove custom toposort typings. (Feat(toposort): Remove custom toposort typings. #27) | [object Object]
    | [object Object]
  • fix(toposort): Remove custom typings as the requested changes in the package were merged. | [object Object]
    |
  • fix(eslint): Change let to const as the variable is not rewrote. |
    ci(multiOS): add windows, osx and linux as matrix for Travis CI (ci(multiOS): add windows, osx and linux as matrix for Travis CI #20) | [object Object]
    |
  • ci(multiOS): add windows, osx and linux as matrix for Travis CI |
    |
  • fix(FileSystemService): readDirectory for symlinks on win32 |
    |
  • ci(config): remove osx pipeline |
    |
  • refactor(FileSystems): remove support for symbolic links |
    |
  • refactor(FileSystems): remove support for symbolic links |
    |
  • fix(FileSystem): win32 os fixed |
    |
  • fix(FileSystem): support win32 arch |
    |
  • fix(FileSystem): support win32 arch |
    |
  • fix(FileSystem): support win32 arch |
    |
  • refactor(VirtualFileSystemService): use memfs instead of own implementation |
    |
  • fixes win support |
    |
  • fix(FileSystem): support win32 arch |
    |
  • fix: all FS tests on OSX |
    |
  • refactor(sharedSubpath): renamed variables and added comment, fixed specs |
    |
  • ci: restrict OS jobs just for pull requests |
    |
  • fix: set separator based on OS |
    |
  • test: review notes resolved |
    |
  • refactor(VirtualFileSystemService): removed duplicated logic with FileSystemService |
    |
  • refactor(FileSystemService): removed VFSS and renamed files to FSS |
    |
  • refactor(FileSystemService): removed VFSS and renamed files to FSS |
    |
  • fix windows |
    |
  • refactor(FileSystemService): removed VFSS and renamed files to FSS |
    |
  • ci: do not verify gpg |
    fix(scanner): pass the scanStrategy parameter into detectProjectComponents() to have a remote url for printing the report | [object Object]
    Use delay() in GitInspector tests | [object Object]
    | [object Object]
    Make GitInspector.getCommits able to specify an end date | [object Object]
    | [object Object]
    Make GitInspector.getCommits able to specify a start date | [object Object]
    | [object Object]
    Make GitInspector.getCommits able to specify an author | [object Object]
    | [object Object]
    Make GitInspector.getCommits able to specify a path | [object Object]
    | [object Object]
    Make GitInspector.getCommits able to specify a commits range | [object Object]
    | [object Object]
    Update src/practices/LanguageIndependent/CIUsedPractice.ts | [object Object]
    | [object Object]
    Co-Authored-By: Prokop Simek prokopsimek@users.noreply.github.com |
    Update src/practices/LanguageIndependent/DependenciesVersionPractice.ts | [object Object]
    | [object Object]
    Co-Authored-By: Prokop Simek prokopsimek@users.noreply.github.com |
    Update src/practices/JavaScript/JsPackageJsonConfigurationSetCorrectlyPractice.ts | [object Object]
    | [object Object]
    Co-Authored-By: Prokop Simek prokopsimek@users.noreply.github.com | [object Object]
    Update src/practices/JavaScript/JsFEBuildToolUsedPractice.ts | [object Object]
    | [object Object]
    Co-Authored-By: Prokop Simek prokopsimek@users.noreply.github.com |
    fix(FileSystemService): switch access fn for lstat | [object Object]
    |
  • access does not support symbolic links |
    doc(CONTRIBUTIN): extend Contribution Guide | [object Object]
    | [object Object]
    WIP: extend README | [object Object]
    | [object Object]
    feat: Add supported languages table | [object Object]
    fix(badge): Fix the travis badge. | body must have leading blank line
    | [object Object]
    fix(text): Extend text about DX Scanner. | [object Object]
    fix(README): add right DX_Heroes twitter | [object Object]
    feat(codeov): add codecov.yml - disable the default statuses Codecov posts | [object Object]
    fix(README): rearrange badges | [object Object]
    feat(README): add updated dependencies badge | [object Object]
    feat(README): add npm downloads badge | [object Object]
    feat(README): add travis badge | [object Object]
    fix(.travis.yml): add script for generating codecov report in .travis.yml | body must have leading blank line
    | [object Object]
    fix(package.json): remove unused script |
    feat(README): add code coverage badge | [object Object]
    WIP(readme): add coverage badge | [object Object]
    | [object Object]
    (fix) repo | [object Object]
    | [object Object]
    (feat) publish org public package | [object Object]
    | [object Object]
    (feat) add last commit badge | [object Object]
    | [object Object]
    (fix) License badge | [object Object]
    | [object Object]
    (feat) add twitter badge | [object Object]
    | [object Object]
    (feat) add .travis.yml | [object Object]
    | [object Object]
    init scanner | [object Object]
    | [object Object]
    init app | [object Object]
    | [object Object]
Update Dependencies of Major Level

Keep the dependencies updated to have all possible features. Use, for example, npm-check-updates. https://github.com/tjunnone/npm-check-updates

Name New Current
@types/node 13.1.4 12.12.24
Use a JS Logging Library

Use a logging library to avoid errors and even cyber attacks. The most widely used logging library in the JavaScript community is Winston. https://www.npmjs.com/package/winston/

🔥 Evaluation of these practices failed - Break down large pull requests into smaller ones

Implementation is not adoption.
We can help you with both. :-)
dxheroes.io

Found a bug? Please report.

@prokopsimek prokopsimek merged commit b4ff0d9 into master Jan 8, 2020
@prokopsimek prokopsimek deleted the hotfix/commit-messages-rules branch January 8, 2020 20:23
@prokopsimek
Copy link
Member Author

🎉 This PR is included in version 1.29.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adelkahomolova adelkahomolova Awaiting requested review from adelkahomolova

Assignees

@prokopsimek prokopsimek

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@prokopsimek