fix: split getIssueState to two methods according to used service

DXHeroes · Jan 20, 2020 · fa61acc · fa61acc
1 parent 3baefeb
commit fa61acc
Showing 1 changed file with 21 additions and 23 deletions.
diff --git a/src/services/git/VCSServicesUtils.ts b/src/services/git/VCSServicesUtils.ts
@@ -32,31 +32,29 @@ export class VCSServicesUtils {
     }
   };
 
-  static getIssueState = (state: IssueState | undefined, service: VCSServiceType) => {
-    if (service === VCSServiceType.github) {
-      switch (state) {
-        case IssueState.open:
-          return GitHubIssueState.open;
-        case IssueState.closed:
-          return GitHubIssueState.closed;
-        case IssueState.all:
-          return GitHubIssueState.all;
-        default:
-          return undefined;
-      }
+  static getGithubIssueState = (state: IssueState | undefined) => {
+    switch (state) {
+      case IssueState.open:
+        return GitHubIssueState.open;
+      case IssueState.closed:
+        return GitHubIssueState.closed;
+      case IssueState.all:
+        return GitHubIssueState.all;
+      default:
+        return undefined;
     }
+  };
 
-    if (service === VCSServiceType.bitbucket) {
-      switch (state) {
-        case IssueState.open:
-          return BitbucketIssueState.new;
-        case IssueState.closed:
-          return BitbucketIssueState.resolved;
-        case IssueState.all:
-          return [BitbucketIssueState.new, BitbucketIssueState.resolved, BitbucketIssueState.closed];
-        default:
-          return undefined;
-      }
+  static getBitbucketIssueState = (state: IssueState | undefined) => {
+    switch (state) {
+      case IssueState.open:
+        return BitbucketIssueState.new;
+      case IssueState.closed:
+        return BitbucketIssueState.resolved;
+      case IssueState.all:
+        return [BitbucketIssueState.new, BitbucketIssueState.resolved, BitbucketIssueState.closed];
+      default:
+        return undefined;
     }
   };
 }