fix(practices): add dependsOn in related practices (#38)

DXHeroes · Aug 20, 2019 · 019ee6a · 019ee6a
1 parent 3860395
commit 019ee6a
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/package.json b/package.json
@@ -34,8 +34,8 @@
     "glob": "^7.1.4",
     "inversify": "^5.0.1",
     "lodash": "^4.17.15",
-    "node-filter-async": "^1.1.3",
     "memfs": "^2.15.5",
+    "node-filter-async": "^1.1.3",
     "npm-check-updates": "^3.1.20",
     "oclif": "^1.13.5",
     "reflect-metadata": "^0.1.13",

diff --git a/src/practices/JavaScript/JsGitignoreCorrectlySetPractice.ts b/src/practices/JavaScript/JsGitignoreCorrectlySetPractice.ts
@@ -10,6 +10,7 @@ import { PracticeContext } from '../../contexts/practice/PracticeContext';
   suggestion: 'Scripts in the .gitignore set as usual.',
   reportOnlyOnce: true,
   url: 'https://github.com/github/gitignore/blob/master/Node.gitignore',
+  dependsOn: { practicing: ['LanguageIndependent.GitignoreIsPresent'] },
 })
 export class JsGitignoreCorrectlySetPractice implements IPractice {
   async isApplicable(ctx: PracticeContext): Promise<boolean> {

diff --git a/src/practices/JavaScript/JsPackageJsonConfigurationSetCorrectlyPractice.ts b/src/practices/JavaScript/JsPackageJsonConfigurationSetCorrectlyPractice.ts
@@ -11,6 +11,7 @@ import { PracticeContext } from '../../contexts/practice/PracticeContext';
     'Use right configuration to automate repetitive tasks. Use build to automate the build process, lint for linting your code, test for testing and start to run your project.',
   reportOnlyOnce: true,
   url: 'https://docs.npmjs.com/files/package.json',
+  dependsOn: { practicing: ['Javascript.PackageManagementUsed'] },
 })
 export class JsPackageJsonConfigurationSetCorrectlyPractice implements IPractice {
   async isApplicable(ctx: PracticeContext): Promise<boolean> {