Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local Settings for Cert Setup for Review #653

Merged
merged 2 commits into from
May 8, 2024
Merged

Local Settings for Cert Setup for Review #653

merged 2 commits into from
May 8, 2024

Conversation

lhr-git
Copy link
Contributor

@lhr-git lhr-git commented May 7, 2024 •
edited
Loading

Description of proposed changes:

  • Removes the hardcoded path from the MSCA NG API cert
  • Adds in the option to disable cert loading for auth disable environments

What to test for/How to test

This shouldn't actually disrupt anything other than on local you can now load a cert from another location (say, locally from ./env.crt)

Additional Notes

@lhr-git lhr-git requested a review from a team as a code owner May 7, 2024 20:19
@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024

Integration Deployment 🚀 - Build Status
Default Tests Workflow Status
Jest Coverage Report
Cypress Coverage Report

krischarbonneau
krischarbonneau approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@krischarbonneau krischarbonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lhr-git lhr-git merged commit 879ea6e into dev May 8, 2024
8 checks passed
@lhr-git lhr-git deleted the lhr-local-cert branch May 8, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krischarbonneau krischarbonneau krischarbonneau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lhr-git @krischarbonneau