generated from DTS-STN/next-template
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
192137 remove banner #622
Merged
Merged
192137 remove banner #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shewood
reviewed
Apr 23, 2024
shewood
reviewed
Apr 23, 2024
shewood
reviewed
Apr 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but a couple of changes for AA needed.
shewood
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADO-192137
Fixed AB#192137
Description of proposed changes:
This PR removes the
PhaseBanner
component as it is no longer being used. This PR also gets rid of the oldMultiModal
component as we are only using a single modal for timeout purposes now and as such has been replaced by the newIdleTimeout
component. This PR also removes the 3 unused mappers and all references to them as they are no longer needed. I have chosen to use local translations for the timeout modal for now as AEM was giving me headaches but we can always explore switching back to using AEM at a later date for this.What to test for/How to test
timeout
andpromptBeforeIdle
in theIdleTimeout
component to something really small (setting the last number to something like 15 as an example)npm run dev
Additional Notes
The Layout unit tests are still being skipped due to issues with how the AA prefix is passed down. This will need to be looked into.