Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert 500 page to ts #555

Merged
merged 4 commits into from
Jan 30, 2024
Merged

convert 500 page to ts #555

merged 4 commits into from
Jan 30, 2024

Conversation

shewood
Copy link
Collaborator

@shewood shewood commented Jan 29, 2024

ADO-163510
Fixed AB#

Changelog - "fix:" for bug fixes, "feat:" for features. Read more about Conventional Commits at https://www.conventionalcommits.org/en/v1.0.0/#summary
Description of proposed changes:
Updated the 500 page to use typescript.
removed unnecessary chaining with non-nullish values as they are now typed as boolean.

What to test for/How to test
500 page should appear as expected.

Additional Notes

@shewood shewood requested a review from a team as a code owner January 29, 2024 21:35
Copy link

Copy link
Contributor

@krischarbonneau krischarbonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shewood shewood merged commit 99c70eb into dev Jan 30, 2024
8 checks passed
@shewood shewood deleted the sch-163510-500 branch January 30, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants