Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reworking server-side errors. #409

Merged
merged 5 commits into from
Oct 30, 2023
Merged

Reworking server-side errors. #409

merged 5 commits into from
Oct 30, 2023

Conversation

nibivi77
Copy link
Contributor

@nibivi77 nibivi77 commented Oct 24, 2023 •
edited by azure-boards bot
Loading

ADO-146355

Fixed AB#146355

Notes

  • This is only for the Dashboard page. If the team agrees with his method, I will apply it for all other pages.
  • For now, error 500 is hardcoded. Apollo does not provide an error code with the .catch(error).

Question

  • Do we agree with this method? I am open for improvements.

@nibivi77
Reworking server-side errors.
9191b2a 
Signed-off-by: Benoit Cloutier <benoit.bc.cloutier@gmail.com>
@nibivi77 nibivi77 requested a review from a team as a code owner October 24, 2023 17:30
@github-actions
Copy link

Integration Deployment 🚀 - Build Status
Default Tests Workflow Status
Jest Coverage Report
Cypress Coverage Report

@nibivi77
Forgot to remove the hardcoded error.
fd93432 
Signed-off-by: Benoit Cloutier <benoit.bc.cloutier@gmail.com>
@nibivi77
Small improvement.
5cda7e1 
Signed-off-by: Benoit Cloutier <benoit.bc.cloutier@gmail.com>
@nibivi77 nibivi77 marked this pull request as draft October 25, 2023 19:52
@nibivi77
Added client-side error handling.
acebb44 
Signed-off-by: Benoit Cloutier <benoit.bc.cloutier@gmail.com>
@nibivi77 nibivi77 marked this pull request as ready for review October 26, 2023 23:16
krischarbonneau
krischarbonneau approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@krischarbonneau krischarbonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nibivi77 nibivi77 merged commit 451bef3 into dev Oct 30, 2023
8 checks passed
@nibivi77 nibivi77 deleted the error-boundary branch October 30, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krischarbonneau krischarbonneau krischarbonneau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nibivi77 @krischarbonneau