Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sch tests 140 #404

Merged
merged 7 commits into from
Oct 19, 2023
Merged

Sch tests 140 #404

merged 7 commits into from
Oct 19, 2023

Conversation

shewood
Copy link
Collaborator

@shewood shewood commented Oct 17, 2023

ADO-140348

Fixed AB#140348

Changelog - "fix:" for bug fixes, "feat:" for features. Read more about Conventional Commits at https://www.conventionalcommits.org/en/v1.0.0/#summary

Description of proposed changes:

Updated some of the tests to fix the console errors for act and undefined
Removed the dts-stn/service-canada-design-system from application.

What to test for/How to test

npm i
run unit tests and look at the console log.
Application continues to work without the DS.

Additional Notes

Still TODO: logout.test

@shewood shewood requested a review from a team as a code owner October 17, 2023 12:29
@github-actions
Copy link

Copy link
Contributor

@krischarbonneau krischarbonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shewood shewood merged commit ceafbf5 into dev Oct 19, 2023
8 checks passed
@shewood shewood deleted the sch-tests-140 branch October 19, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants