Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swapping back to MW-less Docker, also fixing other Dockerfile issue #378

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

lhr-git
Copy link
Contributor

@lhr-git lhr-git commented Sep 20, 2023

ADO-XXX

Fixed AB#
Middleware is still breaking dev, I am still looking into why. We need a functional dev, so this restores the previous state.

I also fixed a final state docker issue that pulled a version of nextjs from the package.json not package-lock.json. Which was causing an error around html-context in nextjs.

Changelog - "fix:" for bug fixes, "feat:" for features. Read more about Conventional Commits at https://www.conventionalcommits.org/en/v1.0.0/#summary

Description of proposed changes:

  • revert to middleware-less version
  • change next_version install line of dockerfile to use package-lock instead of package, ensuring reproducible builds.

What to test for/How to test

If dev loads, it worked.

Additional Notes

@lhr-git lhr-git requested a review from a team as a code owner September 20, 2023 19:41
@github-actions
Copy link

@lhr-git lhr-git merged commit b0d53e6 into dev Sep 21, 2023
7 checks passed
@lhr-git lhr-git deleted the lharrison-devfix-temp branch September 21, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants