Implement Design System header and footer #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nibivi77
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADO-73770
Description
Implemented design system header and footer into layout component
List of proposed changes:
What to test for/How to test
Load application. Index should not have header/footer. Home has header and footer.
Header/footer are bilingual
Header/footer are desktop and mobile friendly
Additional Notes
Header and footer links should navigate to 404 pages since the correct pages do not exist
Links in header are broken for language as they are doing hard loads instead of leveraging nextjs's framework (https://dev.azure.com/VP-BD/DECD/_sprints/taskboard/Secure%20Client%20Hub/DECD/Secure%20Client%20Hub/SCH%20Beta%20Sprint%204?workitem=74636)
Two tests are commented out as DS does not have test ids to ensure the correct component is rendered
https://dev.azure.com/VP-BD/DECD/_sprints/taskboard/Secure%20Client%20Hub/DECD/Secure%20Client%20Hub/SCH%20Beta%20Sprint%204