Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using DS error pages. #203

Merged
merged 7 commits into from
Feb 8, 2023
Merged

Using DS error pages. #203

merged 7 commits into from
Feb 8, 2023

Conversation

nibivi77
Copy link
Contributor

@nibivi77 nibivi77 commented Feb 3, 2023 •
edited
Loading

ADO-102102

Description

  • Added DS Error pages.

Additional Notes

  • Not sure how to tell when a user will be logged in. For now, process.env.AUTH_DISABLED is used.

@nibivi77
Using DS error pages.
dcf2fb2 
Signed-off-by: Benoit Cloutier <benoit.bc.cloutier@gmail.com>
@nibivi77 nibivi77 requested a review from a team as a code owner February 3, 2023 19:03
@github-actions
Copy link

github-actions bot commented Feb 3, 2023

Integration Deployment 🚀 - Build Status
Default Tests Workflow Status
Jest Coverage Report
Cypress Coverage Report

@nibivi77
Merge branch 'dev' into DS-error-pages
4ff8dfe
@nibivi77
Fixed lang toggle.
b80d295 
Signed-off-by: Benoit Cloutier <benoit.bc.cloutier@gmail.com>
@nibivi77
Fixed failing tests.
cc76346 
Signed-off-by: Benoit Cloutier <benoit.bc.cloutier@gmail.com>
numbap
numbap reviewed Feb 6, 2023
View reviewed changes
pages/404.js Show resolved Hide resolved
DaceyTom2
DaceyTom2 suggested changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@DaceyTom2 DaceyTom2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
When throwing an error I get a empty white page with text on it

__tests__/components/skeletons/Dashboard.test.js Show resolved Hide resolved
@nibivi77
Merge branch 'dev' into DS-error-pages
80d92db
@nibivi77
Removed 500.js temporarily.
164e550 
Signed-off-by: Benoit Cloutier <benoit.bc.cloutier@gmail.com>
@nibivi77
Copy link
Contributor Author

nibivi77 commented Feb 8, 2023

I have decided to remove 500.js for the time being as it blocks the rest of the pages.

I will be working on making 500.js function. Seems like a difficult bug to handle so far..

DaceyTom2
DaceyTom2 approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@DaceyTom2 DaceyTom2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nibivi77 nibivi77 merged commit 18b924c into dev Feb 8, 2023
@nibivi77 nibivi77 deleted the DS-error-pages branch February 8, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@numbap numbap numbap left review comments

@DaceyTom2 DaceyTom2 DaceyTom2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nibivi77 @numbap @DaceyTom2