Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

96037 map base url to aem link #183

Merged
merged 9 commits into from
Jan 17, 2023
Merged

Conversation

DaceyTom2
Copy link
Contributor

ADO-96037

Description

Mapped base urls based off AEM property

List of proposed changes:

  • MSCA links now work
  • MSCA links can be configured to each environment

What to test for/How to test

Check MSCA links go to expected spot. (They shouldn't point to our own application)

Additional Notes

@DaceyTom2 DaceyTom2 requested a review from a team as a code owner January 16, 2023 22:10
@github-actions
Copy link

Copy link
Collaborator

@shewood shewood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it out and the links are working, (not the security ones though, they still are broken at the other end)

@DaceyTom2 DaceyTom2 merged commit 0a533d6 into dev Jan 17, 2023
@DaceyTom2 DaceyTom2 deleted the 96037-map-base-url-to-aem-link branch January 17, 2023 17:32
DaceyTom2 added a commit that referenced this pull request Feb 17, 2023
* created AEM queries

* conected banners to AEM queries

* french translations for countdown

* commented out testing buttons

* fixed default content bug

* updated unit testing for modals

* fix: upgrade @apollo/client from 3.7.2 to 3.7.3

Snyk has created this PR to upgrade @apollo/client from 3.7.2 to 3.7.3.

See this package in npm:
https://www.npmjs.com/package/@apollo/client

See this project in Snyk:
https://app.snyk.io/org/p0nder0sa/project/60ffc669-57aa-416f-923d-9c5e8c2c64de?utm_source=github&utm_medium=referral&page=upgrade-pr

* reinstated previous tests

* dashboard test

* removed data files

* merged auth modal queries

* 1

* fixed link localization

* removed console logs

* updated test links

* updated contact us mobile view

* updated test

* skip test for now

* added scripts

* 96037 map base url to aem link (#183)

* mapped links

* mapped profile links

* Added comments

* updated security settings

* removed white space

* spacing

* updated exception link

* updated tests to include contact us link

* added timer

* tested

* fix: upgrade @opentelemetry/auto-instrumentations-node from 0.35.0 to 0.36.0

Snyk has created this PR to upgrade @opentelemetry/auto-instrumentations-node from 0.35.0 to 0.36.0.

See this package in npm:
https://www.npmjs.com/package/@opentelemetry/auto-instrumentations-node

See this project in Snyk:
https://app.snyk.io/org/p0nder0sa/project/60ffc669-57aa-416f-923d-9c5e8c2c64de?utm_source=github&utm_medium=referral&page=upgrade-pr

* updated chevron icon

* added to load icon in case it is needed

* default locale undefined

* Altered meta tags

* Auth dev (#176)

* initial next-auth checkin

* CSP rule for ecas added

* Added auth docker envs

* test

* revert test

* added public jwk

* update csp form action

* remove unused csp

* disabling ssl to test

* removed ssl workaround

* Add cert for srv113

* copy cert file to container

* moved certs directory

* typo for folder

* add ecas base url to build

* hardcoded CSP for srv

* fixed package lock

* added home changes to my-dashboard

* added logout

* added signout callback

* update proxystart namespace

* scrubbing profile sub

* updated package lock

* mcoked lib auth

* disable auth for cypress tests

* added secrets for auth to cypress

* fixed dockerfile typo

* added ut links with env control (#189)

* requested fixes

* New tcs for Contact Us CPP Page

* upgraded Script tag

* async Script tag

* Updated Script tag

* added getStaticProps, kept font swap

* fixed unit test

* removed profile page bug

* .

* removed legacy maps

* .

* updated security policy

* test wihtout adobe

* upt tracking code back in

* alternate script

* async

* synchronoous code added back

* lint exception

* lint exception

* checked bannerBoldText

* added banner content to index

* Added changes to Profile page.

Signed-off-by: Benoit Cloutier <benoit.bc.cloutier@gmail.com>

* fixing tests.

Signed-off-by: Benoit Cloutier <benoit.bc.cloutier@gmail.com>

* fixed e2e

* fixed jest

* .

* .

* -

* -

* Applying requests PR requests.

Signed-off-by: Benoit Cloutier <benoit.bc.cloutier@gmail.com>

* Fixed tests.

Signed-off-by: Benoit Cloutier <benoit.bc.cloutier@gmail.com>

* Unit test fix.

Signed-off-by: Benoit Cloutier <benoit.bc.cloutier@gmail.com>

* Quick fix?

Signed-off-by: Benoit Cloutier <benoit.bc.cloutier@gmail.com>

* Hello

Signed-off-by: Benoit Cloutier <benoit.bc.cloutier@gmail.com>

* skipped one french test

* Update CPPContactUsPO.cy.js

* Update ContactUsCPP.cy.js

* applied recommended changes

* added dynamic data

* 87201 login redirect (#193)

* initial next-auth checkin

* CSP rule for ecas added

* Added auth docker envs

* test

* revert test

* added public jwk

* update csp form action

* remove unused csp

* disabling ssl to test

* removed ssl workaround

* Add cert for srv113

* copy cert file to container

* moved certs directory

* typo for folder

* add ecas base url to build

* hardcoded CSP for srv

* fixed package lock

* added home changes to my-dashboard

* added logout

* added signout callback

* update proxystart namespace

* scrubbing profile sub

* updated package lock

* mcoked lib auth

* disable auth for cypress tests

* added secrets for auth to cypress

* implemented changes

* removed design elements

* added test

* modified test

* fixed dashboard test

* fixed dockerfile typo

* repaired unit test

* removed extra code from mapper

* added requested changes

* removed singout test

---------

Co-authored-by: Thomas Dacey <daceytom2@gmail.com>

* cleanup

* changed static props to server side (#198)

* bug fix

* removed signout from testing

* setup

* updated DS version

* examined each page

* purged orphaned imports

* purged orphaned imports

* updated security

* Using DS error pages.

Signed-off-by: Benoit Cloutier <benoit.bc.cloutier@gmail.com>

* removed lang

* x

* default locale

* fix: upgrade @apollo/client from 3.7.3 to 3.7.4

Snyk has created this PR to upgrade @apollo/client from 3.7.3 to 3.7.4.

See this package in npm:
https://www.npmjs.com/package/@apollo/client

See this project in Snyk:
https://app.snyk.io/org/p0nder0sa/project/60ffc669-57aa-416f-923d-9c5e8c2c64de?utm_source=github&utm_medium=referral&page=upgrade-pr

* fix: upgrade @opentelemetry/sdk-node from 0.34.0 to 0.35.0

Snyk has created this PR to upgrade @opentelemetry/sdk-node from 0.34.0 to 0.35.0.

See this package in npm:
https://www.npmjs.com/package/@opentelemetry/sdk-node

See this project in Snyk:
https://app.snyk.io/org/p0nder0sa/project/60ffc669-57aa-416f-923d-9c5e8c2c64de?utm_source=github&utm_medium=referral&page=upgrade-pr

* added contact-us buttons

* fix build error with getServerSideProps

* Fixed lang toggle.

Signed-off-by: Benoit Cloutier <benoit.bc.cloutier@gmail.com>

* Fixed failing tests.

Signed-off-by: Benoit Cloutier <benoit.bc.cloutier@gmail.com>

* changed AA script url as per request

* fixed permission issue

* updated footer links for authenticated space

* fixed blue highlight

* removed commented out text

* change h to div

* reorder the contact us page links

* feat!: added gh action for changelog generation

* Removed 500.js temporarily.

Signed-off-by: Benoit Cloutier <benoit.bc.cloutier@gmail.com>

* Fixing tests?

Signed-off-by: Benoit Cloutier <benoit.bc.cloutier@gmail.com>

* added id to the button for a11y

* Revert DS error pages.

Signed-off-by: Benoit Cloutier <benoit.bc.cloutier@gmail.com>

* fix: Dockerfile to reduce vulnerabilities

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-ALPINE316-OPENSSL-3314623
- https://snyk.io/vuln/SNYK-ALPINE316-OPENSSL-3314624
- https://snyk.io/vuln/SNYK-ALPINE316-OPENSSL-3314641
- https://snyk.io/vuln/SNYK-ALPINE316-OPENSSL-3314643
- https://snyk.io/vuln/SNYK-ALPINE316-OPENSSL-3314643

* fix: upgrade next-auth from 4.18.8 to 4.18.10

Snyk has created this PR to upgrade next-auth from 4.18.8 to 4.18.10.

See this package in npm:
https://www.npmjs.com/package/next-auth

See this project in Snyk:
https://app.snyk.io/org/p0nder0sa/project/60ffc669-57aa-416f-923d-9c5e8c2c64de?utm_source=github&utm_medium=referral&page=upgrade-pr

* fix so doens't fail if there is no content

* adusted styling for the province info heading

* fix: updated design system

* updated the spacing slightly

* fixed test

---------

Signed-off-by: Benoit Cloutier <benoit.bc.cloutier@gmail.com>
Co-authored-by: “Patrick“ <p@rickjobin.com>
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
Co-authored-by: shewood <28784886+shewood@users.noreply.github.com>
Co-authored-by: CurtisUnderwood <curtisund@gmail.com>
Co-authored-by: Curtis Underwood <53541292+CurtisUnderwood@users.noreply.github.com>
Co-authored-by: shewood <shewood01@gmail.com>
Co-authored-by: Manisha <manisha.sharma@hrsdc-rhdcc.gc.ca>
Co-authored-by: Benoit Cloutier <benoit.bc.cloutier@gmail.com>
Co-authored-by: Benoit Cloutier <77116011+nibivi77@users.noreply.github.com>
Co-authored-by: Kris Charbonneau <71025360+krischarbonneau@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants