Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

88232 Pulling in dropdown text from AEM #149

Merged
merged 1 commit into from
Nov 30, 2022
Merged

88232 Pulling in dropdown text from AEM #149

merged 1 commit into from
Nov 30, 2022

Conversation

CurtisUnderwood
Copy link
Contributor

ADO-88232

Description

List of proposed changes:

  • Card dropdown text now comes form AEM and is unique to dashboard cards

What to test for/How to test

Additional Notes

@CurtisUnderwood CurtisUnderwood requested a review from a team as a code owner November 30, 2022 18:43
@github-actions
Copy link

Integration Deployment 🚀 - Build Status)
Default Tests Workflow Status
Jest Coverage Report
Cypress Coverage Report

DaceyTom2
DaceyTom2 approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@DaceyTom2 DaceyTom2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Talk with Isabelle after about schTasks IDs not matching

@CurtisUnderwood CurtisUnderwood merged commit 2bd7b37 into dev Nov 30, 2022
@CurtisUnderwood CurtisUnderwood deleted the 88232-aem-dropdown branch November 30, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaceyTom2 DaceyTom2 DaceyTom2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CurtisUnderwood @DaceyTom2