Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exit beta tests #131

Merged
merged 17 commits into from
Nov 17, 2022
Merged

Exit beta tests #131

merged 17 commits into from
Nov 17, 2022

Conversation

manishasharma5757
Copy link
Contributor

ADO-87203

Description

List of proposed changes:

  • Test cases for Exit Beta pop up

What to test for/How to test

Additional Notes

@manishasharma5757 manishasharma5757 requested a review from a team as a code owner November 15, 2022 16:10
@github-actions
Copy link

Integration Deployment 🚀 - Build Status)
Default Tests Workflow Status
Jest Coverage Report
Cypress Coverage Report

nibivi77
nibivi77 reviewed Nov 15, 2022
View reviewed changes
Copy link
Contributor

@nibivi77 nibivi77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing wrong with this work. Good work! Just some best practices can be applied. (I did not repeat where the comments can be applied at multiple places.

cypress/e2e/PageObjects/ProfilePO.cy.js Show resolved Hide resolved
cypress/e2e/PageObjects/dashboardPO.cy.js Outdated Show resolved Hide resolved
cypress/e2e/PageObjects/dashboardPO.cy.js Outdated Show resolved Hide resolved
nibivi77
nibivi77 reviewed Nov 17, 2022
View reviewed changes
Copy link
Contributor

@nibivi77 nibivi77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, Again, this work is nice! Just some best coding practices can be applied :)

cypress/e2e/PageObjects/dashboardPO.cy.js Outdated Show resolved Hide resolved
cypress/e2e/PageObjects/ProfilePO.cy.js Show resolved Hide resolved
cypress/e2e/dashboard.cy.js Outdated Show resolved Hide resolved
cypress/e2e/dashboard.cy.js Outdated Show resolved Hide resolved
cypress/e2e/dashboard.cy.js Outdated Show resolved Hide resolved
nibivi77
nibivi77 reviewed Nov 17, 2022
View reviewed changes
Copy link
Contributor

@nibivi77 nibivi77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize these tests are being skipped, but for future use, just a thought, let me know if this is better.

cypress/e2e/dashboard.cy.js Outdated Show resolved Hide resolved
manishasharma5757 and others added 2 commits November 17, 2022 13:20
@manishasharma5757 @nibivi77
Update cypress/e2e/dashboard.cy.js
d8f72bb 
Co-authored-by: Benoit Cloutier <77116011+nibivi77@users.noreply.github.com>
@manishasharma5757
New improvements
936ef1c
nibivi77
nibivi77 approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@nibivi77 nibivi77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good work Manisha thank you!

@manishasharma5757 manishasharma5757 merged commit 4ea4f61 into dev Nov 17, 2022
@manishasharma5757 manishasharma5757 deleted the Exit_Beta_Tests branch November 17, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nibivi77 nibivi77 nibivi77 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manishasharma5757 @nibivi77