Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump dependencies #349

Merged
merged 1 commit into from
Mar 7, 2023
Merged

bump dependencies #349

merged 1 commit into from
Mar 7, 2023

Conversation

sebastien-comeau
Copy link
Contributor

@sebastien-comeau sebastien-comeau commented Mar 7, 2023

Description

List of proposed changes:

  • bump dependencies

What to test for/How to test

Additional Notes

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

@gregory-j-baker
Copy link
Collaborator

Will approve but you should know that these changes don't really do anything.

The caret matcher in package.json matches only the major version.. so when you do "@tanstack/react-query": "^4.26.1", you're effectively doing: "@tanstack/react-query": "^4".

The only reason you see anything updated in the project is because the package-lock.json is being updated to whatever the latest version that matches ^4 is right now.

Copy link
Collaborator

@gregory-j-baker gregory-j-baker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment.

@sebastien-comeau sebastien-comeau merged commit 8d1ef66 into main Mar 7, 2023
@sebastien-comeau sebastien-comeau deleted the bump-dependenies branch March 7, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants