July 2013 OAS deferral #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dynamic branch URL: https://ep-be-dyna-feat/2013-oas-deferral-2.0.bdm-dev-rhp.dts-stn.com |
|
Dynamic branch URL: https://ep-be-dyna-feat/2013-oas-deferral-2.0.bdm-dev-rhp.dts-stn.com |
|
Dynamic branch URL: https://ep-be-dyna-feat/2013-oas-deferral-2.0.bdm-dev-rhp.dts-stn.com |
|
Dynamic branch URL: https://ep-be-dyna-feat/2013-oas-deferral-2.0.bdm-dev-rhp.dts-stn.com |
|
Dynamic branch URL: https://ep-be-dyna-feat/2013-oas-deferral-2.0.bdm-dev-rhp.dts-stn.com |
|
Dynamic branch URL: https://ep-be-dyna-feat/2013-oas-deferral-2.0.bdm-dev-rhp.dts-stn.com |
|
Dynamic branch URL: https://ep-be-dyna-feat/2013-oas-deferral-2.0.bdm-dev-rhp.dts-stn.com |
|
Dynamic branch URL: https://ep-be-dyna-feat/2013-oas-deferral-2.0.bdm-dev-rhp.dts-stn.com |
|
Dynamic branch URL: https://ep-be-dyna-feat/2013-oas-deferral-2.0.bdm-dev-rhp.dts-stn.com |
|
Dynamic branch URL: https://ep-be-dyna-feat/2013-oas-deferral-2.0.bdm-dev-rhp.dts-stn.com |
|
Dynamic branch URL: https://ep-be-dyna-feat/2013-oas-deferral-2.0.bdm-dev-rhp.dts-stn.com |
merging work branch to latest develop
|
Dynamic branch URL: https://ep-be-dyna-feat/2013-oas-deferral-2.0.bdm-dev-rhp.dts-stn.com |
|
Dynamic branch URL: https://ep-be-dyna-feat/2013-oas-deferral-2.0.bdm-dev-rhp.dts-stn.com |
Maxim-Lam
approved these changes
Dec 11, 2023
|
Dynamic branch URL: https://ep-be-dyna-feat/2013-oas-deferral-2.0.bdm-dev-rhp.dts-stn.com |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Dynamic branch URL: https://ep-be-dyna-feat/2013-oas-deferral-2.0.bdm-dev-rhp.dts-stn.com |
|
Dynamic branch URL: https://ep-be-dyna-feat/2013-oas-deferral-2.0.bdm-dev-rhp.dts-stn.com |
andr0272
added a commit
that referenced
this pull request
Dec 20, 2023
* collaps result summary in mobile * title language fix * changed date to 1900 to match error message * Checking in tests * force white background on select * check benefit exists * just to check deployment * update title * final test fixes. * update * change reference to ALWS * change year to 1899 * initial commit * Update build-and-push-dev.yml * Update build-and-push-prod.yml * Update build-and-push-dev.yml * Update build-and-push-prod.yml * fixing trigger and cleanup * fix:updated rates for Q1 2024 * updated links and border color on focus * fix:updated rates for Q1 2024 * fix: removed excess packages * Adding pipeline secrets * Use fieldDefinition instead of categoryMapping * Adding values for variables, removing unused secrets * ADO 134595: Refactor benefitHandler (#960) * Undoing previous commit, cleaning up the variable names * Using a new service principal * July 2013 OAS deferral (#945) Co-authored-by: VeroBr0~ <veronique.breault@cgi.com> Co-authored-by: Veronique B <131703940+VeroBr0@users.noreply.github.com> * updated link anchor for footer * update width * update * Adding the NEXT_AUTH_SECRET variable * Adding the EXPOSE instruction for the proper port of this app * Revert "Q124 rate update" * removing an underscore (#971) * Pipeline underscore (#972) * removing an underscore * testing new home var * Pipeline underscore2 (#974) testing new home var * Fix 143948 * fix for failing tests * Pipeline updates (#977) * Updating pipelines * Updating pipelines * Pipeline underscore (#973) * removing an underscore * testing new home var * testing new home var * clarify comment * Pipeline updates (#978) * Updating pipelines * Updating pipelines * Fixing a docker tag problem --------- Co-authored-by: Jeremy Kennedy <jerekennedy@deloitte.ca> Co-authored-by: Marco <52539578+MarcoGoC@users.noreply.github.com> * added condition for partner legal status * updated dev yml * hotfix typo * Remove leading space in message, fix for 40 years not displaying * added params to current result benefit handler * super hotfix * Merge main (#989) * Updating pipelines * Fixing pipeline files * merge main --------- Co-authored-by: shawn320 <azuneko1110@gmail.com> Co-authored-by: MarcoGoC <marcogoc951@gmail.com> Co-authored-by: Maxim Lam <maxim.lam@hrsdc-rhdcc.gc.ca> Co-authored-by: Marco <52539578+MarcoGoC@users.noreply.github.com> Co-authored-by: Adam <adam.andrews2797@gmail.com> Co-authored-by: Maxim Lam <109530511+Maxim-Lam@users.noreply.github.com> Co-authored-by: Adam Andrews <35509135+andr0272@users.noreply.github.com> Co-authored-by: “Patrick“ <p@rickjobin.com> Co-authored-by: VeroBr0~ <veronique.breault@cgi.com> Co-authored-by: Veronique B <131703940+VeroBr0@users.noreply.github.com> Co-authored-by: Jeremy Kennedy <jerekennedy@deloitte.ca>
alex-solo
added a commit
that referenced
this pull request
Dec 27, 2023
* collaps result summary in mobile * title language fix * changed date to 1900 to match error message * Checking in tests * force white background on select * check benefit exists * just to check deployment * update title * final test fixes. * update * change reference to ALWS * change year to 1899 * initial commit * Update build-and-push-dev.yml * Update build-and-push-prod.yml * Update build-and-push-dev.yml * Update build-and-push-prod.yml * fixing trigger and cleanup * fix:updated rates for Q1 2024 * updated links and border color on focus * fix:updated rates for Q1 2024 * fix: removed excess packages * Adding pipeline secrets * Use fieldDefinition instead of categoryMapping * Adding values for variables, removing unused secrets * ADO 134595: Refactor benefitHandler (#960) * Undoing previous commit, cleaning up the variable names * Using a new service principal * July 2013 OAS deferral (#945) Co-authored-by: VeroBr0~ <veronique.breault@cgi.com> Co-authored-by: Veronique B <131703940+VeroBr0@users.noreply.github.com> * updated link anchor for footer * update width * update * Adding the NEXT_AUTH_SECRET variable * Adding the EXPOSE instruction for the proper port of this app * Revert "Q124 rate update" * removing an underscore (#971) * Pipeline underscore (#972) * removing an underscore * testing new home var * Pipeline underscore2 (#974) testing new home var * Fix 143948 * fix for failing tests * Pipeline updates (#977) * Updating pipelines * Updating pipelines * Pipeline underscore (#973) * removing an underscore * testing new home var * testing new home var * clarify comment * Pipeline updates (#978) * Updating pipelines * Updating pipelines * Fixing a docker tag problem --------- Co-authored-by: Jeremy Kennedy <jerekennedy@deloitte.ca> Co-authored-by: Marco <52539578+MarcoGoC@users.noreply.github.com> * added condition for partner legal status * updated dev yml * hotfix typo * fix:ran scraper * fix:ran scraper * Remove leading space in message, fix for 40 years not displaying * added params to current result benefit handler * super hotfix * Merge main (#989) * Updating pipelines * Fixing pipeline files * merge main --------- Co-authored-by: shawn320 <azuneko1110@gmail.com> Co-authored-by: MarcoGoC <marcogoc951@gmail.com> Co-authored-by: Maxim Lam <maxim.lam@hrsdc-rhdcc.gc.ca> Co-authored-by: Marco <52539578+MarcoGoC@users.noreply.github.com> Co-authored-by: Adam <adam.andrews2797@gmail.com> Co-authored-by: Maxim Lam <109530511+Maxim-Lam@users.noreply.github.com> Co-authored-by: Adam Andrews <35509135+andr0272@users.noreply.github.com> Co-authored-by: “Patrick“ <p@rickjobin.com> Co-authored-by: VeroBr0~ <veronique.breault@cgi.com> Co-authored-by: Veronique B <131703940+VeroBr0@users.noreply.github.com> Co-authored-by: Jeremy Kennedy <jerekennedy@deloitte.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AB#143069 (ADO label)
AB#142328 (ADO label)
Description
Long awaited July 2013 OAS deferral logic. See associated ADO task to get a full idea of requirements. In brief, there are front and "back" end portions to this.
Front-end: When client selects "Yes", they already receive OAS, the deferral dropdown values are populated based on their age in July 2013. If they were between the ages 65-70 at that time, they could have deferred by 70 - age in July 2013.
Back-end: If the client answers "No" to whether they already receive OAS, we need to know what the users age was in July 2013 and based on that calculate the "deferred" scenario (as a reminder, we calculate the deferred and non-deferred scenarios and compare which would provide a more beneficial estimate for the user). The comparison logic is still the same, we just needed to calculate the deferral scenario differently - keeping in mind the "true" number of months the client could have deferred based on the fact that OAS deferral only came into effect in July 2013.
List of proposed changes:
What to test for/How to test
back-end is hard to test, the automated tests do that but should test the front end dropdowns making sure the correct number of years/months are being populated. For example, if the user was over 70 in July 2013, shouldn't have the option to select anything, if they were 67.5, should be able to select up to 2 years and 6 months