Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/mar3 updates #210

Merged
merged 12 commits into from
Mar 4, 2022
Merged

Feature/mar3 updates #210

merged 12 commits into from
Mar 4, 2022

Conversation

KhalidAdan
Copy link
Contributor

@KhalidAdan KhalidAdan commented Mar 3, 2022 •
edited
Loading

The commits should explain what's going on, nothing major going on luckily!

@vercel
Copy link

vercel bot commented Mar 3, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

eligibility-estimator – ./

🔍 Inspect: https://vercel.com/eligibility-estimator/eligibility-estimator/7Gwz6wsCzZWpJ3pLBJekwSQibMKo
✅ Preview: https://eligibility-estimator-git-feature-a37066-eligibility-estimator.vercel.app

@KhalidAdan KhalidAdan marked this pull request as draft March 3, 2022 21:02
@KhalidAdan KhalidAdan force-pushed the feature/mar3-updates branch from f9de9d6 to bacbd4b Compare March 3, 2022 21:03
@KhalidAdan KhalidAdan marked this pull request as ready for review March 4, 2022 16:19
@KhalidAdan KhalidAdan requested a review from JeremyKennedy March 4, 2022 17:30
@KhalidAdan KhalidAdan enabled auto-merge (squash) March 4, 2022 17:52
@KhalidAdan KhalidAdan force-pushed the feature/mar3-updates branch from 34a6a3b to 0378921 Compare March 4, 2022 21:58
JeremyKennedy
JeremyKennedy approved these changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@JeremyKennedy JeremyKennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All issues were mentioned on Teams and resolved! Looks good!

Khalid and others added 12 commits March 4, 2022 17:23
@JeremyKennedy
Added updated english text for apply blurb; padding updates; text cha…
76a9c20 
…nges for english; Fixed FAQ header for CPP
@JeremyKennedy
Added spacing to social agreement FAQ item
aeb63e5
@JeremyKennedy
Fixed income details category top margin
81a0f21
@JeremyKennedy
Added a guard against income being empty and sending an incorrect api…
e062e83 
… request
@JeremyKennedy
Fixed test failure; Fixed mobile bug where tooltips forced the mobile…
4bf6c14 
… keyboard to remain open
@JeremyKennedy
Fixed capitalization in privacy notice header
3dfbc76
@JeremyKennedy
Added text changes from analyst
b8e71b3
@JeremyKennedy
Removing bolding that incorrectly was added
3b8ea22
@JeremyKennedy
Fixed required bolding issue and made sure the tooltips where placed …
65eae85 
…inline with the label
@JeremyKennedy
Fixed colours in the ResultsTable
1e426cd
@JeremyKennedy
font colour should default to #333
dc35d11
@JeremyKennedy
small cleanup
3cb4318
@JeremyKennedy JeremyKennedy force-pushed the feature/mar3-updates branch from 28756b6 to 3cb4318 Compare March 4, 2022 22:24
@KhalidAdan KhalidAdan merged commit dd47de5 into develop Mar 4, 2022
@KhalidAdan KhalidAdan deleted the feature/mar3-updates branch March 4, 2022 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeremyKennedy JeremyKennedy JeremyKennedy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KhalidAdan @JeremyKennedy