Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix page reloading bug by switching to local implementation #209

Merged
merged 7 commits into from
Mar 4, 2022

Conversation

JeremyKennedy
Copy link
Contributor

@JeremyKennedy JeremyKennedy commented Mar 2, 2022

By making 100% of the app logic local, this simplifies many things:

  • infrastructure: now there is only static content to deploy, no need to worry about an API or serverless functions or cold starts
  • frontend behavior: instead of having to make a network request and wait for a response, the frontend is now able to instantly process data, meaning the app processing is super fast, and needs no internet connection (once loaded)
  • deployment: there's no fancy "static site generation" or "server site properties" or whatever fancy web magic Next.JS offers, just a simple static site

Initially we went with the backend API approach for app logic as we were considering databases, authentication, and whatnot, but that is all out of scope. Adobe Analytics is implemented and is all we need.

@vercel
Copy link

vercel bot commented Mar 2, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

eligibility-estimator – ./

🔍 Inspect: https://vercel.com/eligibility-estimator/eligibility-estimator/8gxn1YPQA5d77hRFLZsh6rGGxwHa
✅ Preview: https://eligibility-estimator-git-feature-3506f2-eligibility-estimator.vercel.app

@JeremyKennedy JeremyKennedy requested a review from KhalidAdan March 2, 2022 22:19
@JeremyKennedy JeremyKennedy force-pushed the feature/fix_page_reloading branch from 77009b4 to c3101d5 Compare March 2, 2022 22:43
Copy link
Contributor

@KhalidAdan KhalidAdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with this, but just left a thought that we could chat about at any time really. The solution came out clean!

client-state/models/Form.ts Outdated Show resolved Hide resolved
@JeremyKennedy JeremyKennedy force-pushed the feature/fix_page_reloading branch from ab74ed5 to 2ba47c3 Compare March 4, 2022 22:35
@JeremyKennedy JeremyKennedy force-pushed the feature/fix_page_reloading branch from 2ba47c3 to 9b218f8 Compare March 4, 2022 22:37
@JeremyKennedy JeremyKennedy changed the title fix page reloading Fix page reloading bug by switching to local implementation Mar 4, 2022
@JeremyKennedy JeremyKennedy merged commit 384c4a5 into develop Mar 4, 2022
@JeremyKennedy JeremyKennedy deleted the feature/fix_page_reloading branch March 4, 2022 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants