-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix page reloading bug by switching to local implementation #209
Conversation
This pull request is being automatically deployed with Vercel (learn more). eligibility-estimator – ./🔍 Inspect: https://vercel.com/eligibility-estimator/eligibility-estimator/8gxn1YPQA5d77hRFLZsh6rGGxwHa |
77009b4
to
c3101d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with this, but just left a thought that we could chat about at any time really. The solution came out clean!
ab74ed5
to
2ba47c3
Compare
…is no longer used (but still works)
…d for the csv function
2ba47c3
to
9b218f8
Compare
By making 100% of the app logic local, this simplifies many things:
Initially we went with the backend API approach for app logic as we were considering databases, authentication, and whatnot, but that is all out of scope. Adobe Analytics is implemented and is all we need.