Change Enter to Done on mobile #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). eligibility-estimator – ./🔍 Inspect: https://vercel.com/eligibility-estimator/eligibility-estimator/529og4PuyumAmHqLntaMa9QedzP4 |
This reverts commit 30bab0d. # Conflicts: # components/Forms/CurrencyField.tsx # components/Forms/NumberField.tsx
JeremyKennedy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On mobile, during user testing we saw users press the Enter button after they enter an age or an income. Previously, this would result in submitting the form, which would either fill the page with "this field is required" errors, or abruptly bring them to the results page. Now, the user's keyboard will be updated with a "done" button (a checkmark on Android), and pressing it will hide the keyboard rather than submitting the form.
The below screenshots show the difference in the keyboard's Enter button:
Before:
After:
