Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/mar1 updates #206

Merged
merged 13 commits into from
Mar 3, 2022
Merged

Feature/mar1 updates #206

merged 13 commits into from
Mar 3, 2022

Conversation

KhalidAdan
Copy link
Contributor

@KhalidAdan KhalidAdan commented Mar 2, 2022 •
edited
Loading

Pass Numero dos at updating the items brought up in the mar1 meeting

  • Updated search bar to show
  • Added header and blurb for apply buttons (Need translation)
  • Refactored the FAQ
  • Updated home page to use bullet points
  • semibold was causing too many issues, so we are just going to stick with bold
  • miscelleaneous fixes for form field components for spacing and display
  • Tooltips needed some love on mobile and desktop, so we now make them have consistent width on mobile and add a margin, as well as making them thinner on desktop
  • Error labels were lightly edited to make them appear closer to the form field they were attached to and position them farther from the label

@vercel
Copy link

vercel bot commented Mar 2, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

eligibility-estimator – ./

🔍 Inspect: https://vercel.com/eligibility-estimator/eligibility-estimator/BPA1EiBCqYVU3Ne7dc2NoM4dbJzB
✅ Preview: https://eligibility-estimator-git-feature-1a2ec3-eligibility-estimator.vercel.app

@KhalidAdan KhalidAdan force-pushed the feature/mar1-updates branch from 583f520 to acf297e Compare March 2, 2022 17:14
Khalid added 4 commits March 2, 2022 12:15
Updated the search bar
ef9ddbf
parent a202b14
32b6b6b 
author Khalid <kadan@deloitte.ca> 1646235897 -0500
committer Khalid <kadan@deloitte.ca> 1646241054 -0500
gpgsig -----BEGIN PGP SIGNATURE-----

 iQIzBAABCAAdFiEE8fuZ4nkBHmAYMOrAk39odjSKU+gFAmIfpR4ACgkQk39odjSK
 U+gVlhAAskP1j8yNGyuIBjD/58jQaZfVZEe2GowRFl+ZeL2Iys3iMt6VhKl9w7KS
 cu3HQIsZNTh0TmjXW+cQOzbEKGSfHYGahLnkM/Nqjg0siMZDhRUWzwAousn7UGaT
 5xIgUKhHm/hvI1JDtLLBs/YMfI7rzV2rAq7oa64j0e+tw7YlVgF4GJkqN/y+d+4c
 tJcSCkae5OnAAtOVuBWi1QeHuG3/uCojKtTGzryDm71dO+h+bmT21Gvtg/7IbBI4
 7O6eUu9RwTW3+UAGaoQWPo9sZYHS9ggDWnD/A4gW4K+diTxcl/kp7ij8b1Jz8Brh
 30q3s+5rP9A5F9gqwztcYKaqMDrRd4uPEJCJWVQOls+Gl4x2Y7uzGDqXuvZJ5z55
 pmPlYqGcEOHa9BOqfr5kuP0MZ/Azdh3+4b4QM7qz0/tASEaYbWqtSisD4zV8X1hf
 7sGLzKVU6wDvRpQl7He+6e+MSj8A7N4qLxv4muRNPMnGdbzY+RCSZOERekROP8Qz
 1F8GV/LyUMsRrhjIxQyosBTadvE4hHScgJLRy/UVOj6o3fZhcDOath44xd+LJdUu
 TmiFP2c71BN+1weZPCo7rP+GsM1HdgKv9U15y5+6V8v6tV5dV0V5ta5HddYmfdz/
 oimIEoludXd4QoPTmtWfq2YP2338wVRGolMwgqqIggPecquWtGs=
 =c/3O
 -----END PGP SIGNATURE-----

parent a202b14
author Khalid <kadan@deloitte.ca> 1646235897 -0500
committer Khalid <kadan@deloitte.ca> 1646241025 -0500
gpgsig -----BEGIN PGP SIGNATURE-----

 iQIzBAABCAAdFiEE8fuZ4nkBHmAYMOrAk39odjSKU+gFAmIfpQIACgkQk39odjSK
 U+iVZA/+Lpby8piPnqtOIGhrQWWV6zQcwsj3/FuuxG7R4KvAj1iaOgteF0V4ChcL
 G0EwPeE2owA9Y6yzBOdUPOFEaS4ZGulLZ0QWAzzLpKeMOiVPVjgQw9L0WdqgofOv
 FDvafhkoGt5APrwEG99Ivhb4WVBofBTWxekkjBySEEC3ROAdQ0aTNCcRopgtDkY5
 Hwqv/L7i8T7PbHxGyj4CnaqBoom7u885Qe45N8qWrF76Gagri8oJ9K4lRhZjd5cc
 j1swxjl7OZPopr+SP3lXhtp0tBfH+taL+AiUul3M6jagmkA810+NMn4Je6KuCbJS
 mjbuBuml5wm2bVRHwA3pcIJ72IdaScpIldzDgXi89G7H8zOt3wJ1/6zQLzySpIYt
 uHGpF/jfH7qm+oGqTqU3+7BfXzVLvSk5REgjvS3vKhdRD8WdDK6ha2wBvP+SUcsK
 syimf1lf5GkDip3QJkGvex00mUlmz2UY6JqcXepOSasCUXuXnYFhMSAwqvaj3WyE
 x7eV2RA/EE9rO5hFtgNeqnCv6hmoveQas1XH0vAzawUIPk02uvOxTnWSPDdtdUxW
 iD541eg53+G8zRgVNtYaoJ7P3Rn5KkCYBU2ZdUVNwxHLah26qfN8J5zeZJoClre2
 yQkthbrnlXSnRfK5/FvTimlQhJTqNq9yBcWDaoGK1QXNStCqJoU=
 =p4TF
 -----END PGP SIGNATURE-----

added bullet points to the front page
Added new header and blurb about the apply buttons
837778e 
Added new apply part
Added french FAQ and updated
432f120
@KhalidAdan KhalidAdan force-pushed the feature/mar1-updates branch from acf297e to 432f120 Compare March 2, 2022 17:16
@KhalidAdan KhalidAdan requested a review from JeremyKennedy March 2, 2022 20:57
JeremyKennedy
JeremyKennedy approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@JeremyKennedy JeremyKennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added an oxford comma, fixed some French. Good to go!

@KhalidAdan KhalidAdan merged commit 585a021 into develop Mar 3, 2022
@KhalidAdan KhalidAdan deleted the feature/mar1-updates branch March 3, 2022 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeremyKennedy JeremyKennedy JeremyKennedy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KhalidAdan @JeremyKennedy