Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

185038 income labels #1052

Merged
merged 6 commits into from
May 17, 2024
Merged

185038 income labels #1052

merged 6 commits into from
May 17, 2024

Conversation

MarcoGoC
Copy link
Contributor

@MarcoGoC MarcoGoC commented May 13, 2024

AB#185038 - Changes to Labels, Hint Description for Main Income field

Description

  • As per task

List of proposed changes:

  • see task

What to test for/How to test

  • run and compare changes to the task requests

Additional Notes

@MarcoGoC MarcoGoC requested review from alex-solo and Maxim-Lam May 13, 2024 21:02
Copy link

Copy link
Collaborator

@alex-solo alex-solo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

The work income question is optional, but it should prefill or automatically fill with 0 and allow the user to click "Next" to proceed to the next card.

Copy link

Copy link

@MarcoGoC MarcoGoC requested a review from alex-solo May 15, 2024 21:21
@MarcoGoC MarcoGoC dismissed alex-solo’s stale review May 15, 2024 21:22

added and fixed the required that wasn't working for main income

Copy link

Copy link
Collaborator

@alex-solo alex-solo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

It's still a bit confusing for the user if they delete the input and it's empty, they cannot proceed. But maybe a question for Andreanne about the specific behaviour that is required.

@MarcoGoC MarcoGoC merged commit e090abb into develop May 17, 2024
4 checks passed
@MarcoGoC MarcoGoC deleted the 185038-IncomeLabels branch May 17, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants