Fix #71: delete redundant copy of file in replica store #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delete redundant file copy in replica store
|
Hi @amgciadev! My apologies for the delay in getting to this PR. One problem I've had is that I don't have easy access to a mountable filesystem to test it. I read the issue description in #71, and the description in the MountableObjectStore class, and it seems like this is expected behavior. In https://github.com/DSpace/dspace-replicate/blob/main/src/main/java/org/dspace/ctask/replicate/store/MountableObjectStore.java it states that the MountableObjectStore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #71. It modifies the transferObject method of MountableObjectStore to delete the redundant file copy in replica store, to match the behaviour of LocalObjectStore.