-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for User profile (/profile): only 20 group memberships shown instead of all #3105
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VictorHugoDuranS : Thanks! We also reviewed this PR together as a team in our DSpace Developer Meeting. The feedback here is similar. We need to have a PR created against main
so that we can apply these changes to 8.x and 9.0. Overall, though, the code looks reasonable (except for the one note by @artlowel above).
We didn't get a chance to test this, but I'll volunteer to help test it (if no one else gets to it) once we have a version of this PR against the main
branch
Hi @VictorHugoDuranS, |
# Conflicts: # src/app/profile-page/profile-page.component.ts # src/assets/i18n/ar.json5 # src/themes/custom/lazy-theme.module.ts
@tdonohue I merged the main branch to this branch with the current changes. Thanks for the feedback!. |
Hi @tdonohue , I'm @jtimal partner, I like to share this PR with you:
References
Description
Set pagination on groups of the user on profile page
Instructions for Reviewers
On the profile page I added the pagination of groups adding the pagination template and modifying the current service of groups for paginated it. I set 20 elements par page as default in the pagination
List of changes in this PR:
Example:
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
yarn lint
yarn check-circ-deps
)package.json
), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.