Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for User profile (/profile): only 20 group memberships shown instead of all #3105

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

VictorHugoDuranS
Copy link
Contributor

@VictorHugoDuranS VictorHugoDuranS commented Jun 7, 2024

Hi @tdonohue , I'm @jtimal partner, I like to share this PR with you:

References

Description

Set pagination on groups of the user on profile page

Instructions for Reviewers

On the profile page I added the pagination of groups adding the pagination template and modifying the current service of groups for paginated it. I set 20 elements par page as default in the pagination

List of changes in this PR:

  • I created a default variable for group pagination
  • I changed the template of group list adding the pagination template
  • I added the 'PaginationService' for get the current page in the pagination
  • I changed the current services for get groups of the user adding 'Pagination Service' and add the option for paginate the groups, so the pagination component change the current page update the results

Example:

image image

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added 1 APPROVAL pull request only requires a single approval to merge bug port to main This PR needs to be ported to `main` branch for the next major release labels Jun 7, 2024
@tdonohue tdonohue changed the title Dspace 7 2357 Fix for User profile (/profile): only 20 group memberships shown instead of all Aug 8, 2024
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VictorHugoDuranS : Thanks! We also reviewed this PR together as a team in our DSpace Developer Meeting. The feedback here is similar. We need to have a PR created against main so that we can apply these changes to 8.x and 9.0. Overall, though, the code looks reasonable (except for the one note by @artlowel above).

We didn't get a chance to test this, but I'll volunteer to help test it (if no one else gets to it) once we have a version of this PR against the main branch

@VictorHugoDuranS VictorHugoDuranS changed the base branch from dspace-7_x to main September 7, 2024 00:05
Copy link

github-actions bot commented Sep 7, 2024

Hi @VictorHugoDuranS,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

# Conflicts:
#	src/app/profile-page/profile-page.component.ts
#	src/assets/i18n/ar.json5
#	src/themes/custom/lazy-theme.module.ts
@tdonohue tdonohue added port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release and removed port to main This PR needs to be ported to `main` branch for the next major release labels Sep 9, 2024
@VictorDuranEscire
Copy link

@tdonohue I merged the main branch to this branch with the current changes. Thanks for the feedback!.
I will be waiting for your response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge bug port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release
Projects
Status: 👀 Under Review
Development

Successfully merging this pull request may close these issues.

User profile (/profile): only 20 group memberships shown instead of all
4 participants