Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed home page links being unclickable #2945

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

alexandrevryghem
Copy link
Member

References

Description

In the previous PR I did not realise that the ds-themed-configuration-search-page already used the ds-page-with-sidebar. In that PR I added an extra ds-page-with-sidebar around the ds-themed-configuration-search-page causing it's empty floating content column to block clickevents on the components underneath it. This PR refactors the home page to use the ds-page-with-sidebar inside the ds-themed-configuration-search-page instead, this is done with the new content projection selector searchContentTop.

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@alexandrevryghem alexandrevryghem self-assigned this Apr 16, 2024
@alexandrevryghem alexandrevryghem added bug testathon Reported by a tester during Community Testathon labels Apr 16, 2024
@tdonohue tdonohue self-requested a review April 17, 2024 13:51
@tdonohue tdonohue added this to the 8.0 milestone Apr 17, 2024
@Leano1998
Copy link
Contributor

I've tested it and it works for me. Thanks @alexandrevryghem

Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @alexandrevryghem ! I also tested briefly and found this fixes the bug

@tdonohue tdonohue merged commit 57b0efe into DSpace:main Apr 19, 2024
13 checks passed
@alexandrevryghem alexandrevryghem deleted the home-page-facet-fixes branch May 15, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug testathon Reported by a tester during Community Testathon
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

When "Discover" sidebar is enabled on homepage, some Community links are unclickable
3 participants