Skip to content

Commit

Permalink
Don't use .preserve-line-breaks for Markdown content
Browse files Browse the repository at this point in the history
The Markdown parser generates HTML with headings, paragraphs, ... for each bit of text.
This results in extra vertical spacing if we use `white-space: pre-line`
  • Loading branch information
ybnd committed Oct 20, 2022
1 parent 8204481 commit 6918239
Showing 1 changed file with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
<ds-metadata-field-wrapper [label]="label | translate">
<ng-container *ngFor="let mdValue of mdValues; let last=last;">
<ng-container *ngTemplateOutlet="(renderMarkdown ? markdown : simple); context: {value: mdValue.value, classes: 'dont-break-out preserve-line-breaks'}">
<ng-container *ngTemplateOutlet="(renderMarkdown ? markdown : simple); context: {value: mdValue.value}">
</ng-container>
<span class="separator" *ngIf="!last" [innerHTML]="separator"></span>
</ng-container>
</ds-metadata-field-wrapper>

<ng-template #markdown let-value="value" let-classes="classes">
<span class="{{classes}}" [innerHTML]="value | dsMarkdown | async">
<ng-template #markdown let-value="value">
<span class="dont-break-out" [innerHTML]="value | dsMarkdown | async">
</span>
</ng-template>

<ng-template #simple let-value="value" let-classes="classes">
<span class="{{classes}}">{{value}}</span>
<ng-template #simple let-value="value">
<span class="dont-break-out preserve-line-breaks">{{value}}</span>
</ng-template>

0 comments on commit 6918239

Please sign in to comment.