Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/v 2.3.1 #72

Merged
merged 3 commits into from
Dec 21, 2022
Merged

Release/v 2.3.1 #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4c0b442
Fix alFunctionItem conversion
DominicSaladin Dec 21, 2022
5b080cf
Update to version 2.3.1
DominicSaladin Dec 21, 2022
a917ac0
Update changelog
DominicSaladin Dec 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
# Change Log
All versions of AL Object Helper will be documented in this file.

## [2.3.1] - 2022-12-21
### Fix
- ALFunction is not a function (Fixes [#71](https://github.com/DSaladinCH/al-object-helper/issues/71))

## [2.3.0] - 2022-12-06
### Add
- Performance Modes
Expand Down Expand Up @@ -226,6 +230,7 @@ All versions of AL Object Helper will be documented in this file.
## [1.0.0] - 2020-06-24
- Initial release

[2.3.1]: https://github.com/DSaladinCH/al-object-helper/compare/2.3.0...2.3.1
[2.3.0]: https://github.com/DSaladinCH/al-object-helper/compare/2.2.13...2.3.0
[2.2.13]: https://github.com/DSaladinCH/al-object-helper/compare/2.2.12...2.2.13
[2.2.12]: https://github.com/DSaladinCH/al-object-helper/compare/2.2.10...2.2.12
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"name": "Dominic Saladin"
},
"license": "MIT",
"version": "2.3.0",
"version": "2.3.1",
"icon": "Images/ALObjectHelper_Small.png",
"engines": {
"vscode": "^1.63.0"
Expand Down
8 changes: 4 additions & 4 deletions src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ export async function activate(context: vscode.ExtensionContext) {
return;
}

const quickPick = new QuickPickManagement<ALFunction>();
const quickPick = new QuickPickManagement<ALFunctionItem>();
const picked = quickPick.create(`Select event from ${ObjectType[alObject.objectType]} "${alObject.objectName}" to copy`);

alObject = await reader.readAlObject(alObject);
Expand All @@ -112,13 +112,13 @@ export async function activate(context: vscode.ExtensionContext) {
).forEach(alFunction => alFunctionItems.push(new ALFunctionItem(alObject!, alFunction, true)));

quickPick.updateValue(alFunctionItems);
const alFunction = await picked;
const alFunctionItem = await picked;

if (!alFunction) {
if (!alFunctionItem) {
return;
}

await vscode.env.clipboard.writeText(alFunction.getEventSubscriberText(alObject));
await vscode.env.clipboard.writeText(alFunctionItem.alFunction.getEventSubscriberText(alObject));
vscode.window.showInformationMessage("Copied to Clipboard!");
}));

Expand Down