Skip to content
This repository has been archived by the owner on Aug 19, 2024. It is now read-only.

BLD: added newline for all json nominee files #48

Merged
merged 1 commit into from
Aug 3, 2020
Merged

BLD: added newline for all json nominee files #48

merged 1 commit into from
Aug 3, 2020

Conversation

lacabra
Copy link
Contributor

@lacabra lacabra commented Aug 3, 2020

This pull request adds a newline to each JSON nominee file. The rationale is that given that JSON files are text files, which are defined as (see this answer from unix.stackexchange):

A text file, under unix, consists of a series of lines, each of which ends with a newline character (\n). A file that is not empty and does not end with a newline is therefore not a text file.

*nix systems expect text files to be ended with an empty newline, otherwise some text-file-processing utilities and applications will break if this is not followed. This PR ensures that all JSON files will be properly treated as text files.

This PR does the following:

  • Modified the scripts that the CI runs to allow for newlines at the end of JSON files
  • Actually modifying all JSON files in the repo adding a newline at the end

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant