support subclassing ACE_Connector

[esohns]

make "flags_" member protected so it can be reached from children

Summary by CodeRabbit

• Refactor
  • Enhanced the connector’s internal configuration to enable improved flexibility for advanced customization without affecting current functionality.

[coderabbitai]

Walkthrough

The update modifies the ACE_Connector class in the ACE/ace/Connector.h file by moving the variable declaration of "int flags_". Previously located in the private section, this variable is now declared in the protected section, allowing derived classes direct access. The associated comments remain unchanged, maintaining the variable's role in non-blocking I/O initialization.

Changes

File	Change Summary
ACE/ace/Connector.h	Moved the declaration of "int flags_” from the private section to the protected section in ACE_Connector.

Poem

I hopped through lines of code so neat,
Flags found new grounds—they now compete!
No more hidden in private’s keep,
In protected fields, they freely leap.
With a wiggle and a twitch, I'm over the log,
CodeRabbit cheers this change—hop along in the fog!
🐇💻

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

ACE/ace/Connector.h (1)

284-292: LGTM! Good architectural improvement.

Moving the flags_ member to the protected section is a well-thought-out change that improves the extensibility of the ACE_Connector class. This modification allows derived classes to access and customize the SVC_HANDLER initialization flags while maintaining proper encapsulation.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bf1a53c and f5d0df0.

📒 Files selected for processing (1)

• ACE/ace/Connector.h (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (20)

• GitHub Check: ubuntu-20.04 g++-10 ACE for TAO
• GitHub Check: ubuntu-20.04 clang++-11
• GitHub Check: Codacy Static Code Analysis
• GitHub Check: ubuntu-20.04 clang++-10
• GitHub Check: VS2022Release64
• GitHub Check: VS2022Debug64
• GitHub Check: VS2022WChar
• GitHub Check: VS2019Debug64Cxx20
• GitHub Check: VS2019Debug64Cxx17
• GitHub Check: VS2019Release32
• GitHub Check: VS2019Debug32
• GitHub Check: VS2019Release64
• GitHub Check: VS2019Debug64
• GitHub Check: VS2019WChar
• GitHub Check: MINGW64-gcc
• GitHub Check: windows-2019 vs2019
• GitHub Check: macos-14-C++
• GitHub Check: macos-13-C++
• GitHub Check: ubuntu-20.04 g++-10
• GitHub Check: alpine-3.18