Added deprecated attribute to ACE_Copy_Disabled #2324
Conversation
* ACE/ace/Copy_Disabled.h:
WalkthroughThe change introduces a deprecation notice to the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (4)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (21)
🔇 Additional comments (5)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
ACE/ace/Copy_Disabled.h (1)
24-45: Consider updating class documentation with migration instructions.Since this class is now deprecated, it would be helpful to update the class documentation to:
- Mention that it's deprecated
- Provide a migration path for users
- Explain why direct usage of
=deleteis preferredAdd migration guidance to the documentation:
* To use this class simply use private inheritance: * * class Foo : private ACE_Copy_Disabled * { * // code here * }; + * + * @deprecated This class is deprecated. Instead of using inheritance, + * directly delete copy operations in your class: + * + * class Foo { + * public: + * Foo() = default; + * Foo(const Foo&) = delete; + * Foo(Foo&&) = delete; + * Foo& operator=(const Foo&) = delete; + * Foo& operator=(Foo&&) = delete; + * }; */Also applies to: 46-57
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
ACE/ace/Copy_Disabled.h(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (21)
- GitHub Check: ubuntu-20.04 g++-10 CodeQL
- GitHub Check: ubuntu-20.04 g++-10 ACE for TAO
- GitHub Check: ubuntu-20.04 g++-10 CORBA/e micro
- GitHub Check: ubuntu-22.04 clang++-16
- GitHub Check: ubuntu-22.04 clang++-15
- GitHub Check: ubuntu-22.04 clang++-14
- GitHub Check: ubuntu-20.04 clang++-13
- GitHub Check: ubuntu-20.04 clang++-12
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: ubuntu-20.04 clang++-11
- GitHub Check: ubuntu-20.04 clang++-10
- GitHub Check: ubuntu-20.04 clang++-9
- GitHub Check: ubuntu-20.04 clang++-8
- GitHub Check: ubuntu-20.04 clang++-7
- GitHub Check: ubuntu-20.04 clang++-6.0
- GitHub Check: ubuntu-24.04 g++-13
- GitHub Check: ubuntu-22.04 g++-12
- GitHub Check: ubuntu-22.04 g++-11
- GitHub Check: ubuntu-20.04 g++-10
- GitHub Check: windows-2019 vs2019
- GitHub Check: alpine-3.18
🔇 Additional comments (1)
ACE/ace/Copy_Disabled.h (1)
46-57: Verify impact on existing codebase.Since this is a helper class that's used through inheritance, we should verify the impact of deprecation on the codebase.
Let's search for classes inheriting from ACE_Copy_Disabled:
✅ Verification successful
🏁 Script executed:
#!/bin/bash # Search for classes inheriting from ACE_Copy_Disabled rg -l ":\s*(private|protected|public)\s+ACE_Copy_Disabled"Length of output: 115
Reviewing ACE_Copy_Disabled deprecation impact
- The only occurrences matching an inheritance pattern were in
ACE/ace/Copy_Disabled.hitself and in the changelog (ACE/ChangeLogs/ChangeLog-2002a), which is merely documentation and not active code.- No actual class in the codebase inherits from
ACE_Copy_Disabled, indicating that the deprecation has no runtime impact on current functionality.
* ACE/ace/Copy_Disabled.h:
* ACE/ace/Copy_Disabled.cpp:
Deleted.
* ACE/ace/Copy_Disabled.h:
* ACE/ace/ace.mpc:
* ACE/ace/ace_for_tao.mpc:
* ACE/ace/Copy_Disabled.h:
* ACE/ace/Copy_Disabled.h:
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
jwillemsen
changed the title
Summary by CodeRabbit