Changed the default to C++17 for QNX and g++ versions older as 11 (11… #2212
Conversation
… has C++17 as default)
* ACE/include/makeinclude/platform_g++_common.GNU:
* ACE/include/makeinclude/platform_qnx_gcc.GNU:
…into jwi-defaultcpp17
| ifeq ($(findstring $(CXX_MAJOR_VERSION),7),$(CXX_MAJOR_VERSION)) | ||
| c++std ?= c++17 | ||
| endif | ||
| ifeq ($(findstring $(CXX_MAJOR_VERSION),8),$(CXX_MAJOR_VERSION)) | ||
| c++std ?= c++17 | ||
| endif | ||
| ifeq ($(findstring $(CXX_MAJOR_VERSION),9),$(CXX_MAJOR_VERSION)) | ||
| c++std ?= c++17 | ||
| endif | ||
| ifeq ($(findstring $(CXX_MAJOR_VERSION),10),$(CXX_MAJOR_VERSION)) |
There was a problem hiding this comment.
This looks like this would match versions 17, 18, 19, 27, etc. If this was run with those versions it would downgrade the standard being used if the user didn't set c++std.
There was a problem hiding this comment.
This matches the code we had in the past for C++11, will have a look at this before the next micro, feel free to open a PR
| @@ -74,6 +74,20 @@ endif | |||
|
|
|||
| CXX_FULL_VERSION := $(shell $(CXX_FOR_VERSION_TEST) --version) | |||
|
|
|||
| # Minimum C++ level is now C++17, gcc until version 11 have an older version as default | |||
There was a problem hiding this comment.
This isn't consistent with what the title of PR is. I'm also still not sure what the purpose of changing the default from the compiler default is. Does ACE still compile with C++14?
There was a problem hiding this comment.
ACE master currently compiles with C++14, this is a first step towards C++17 as minimum required level. Someone has to dive into the microsoft support, when we have there C++17 as default I plan to move C++17 as minimum level
… has C++17 as default)