Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2119: Improve documentation for TAO_UIPMC_Protocol_Factory and TAO_MIOP_Resource_Factory #2120

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Fix #2119: Improve documentation for TAO_UIPMC_Protocol_Factory and TAO_MIOP_Resource_Factory #2120

merged 1 commit into from
Oct 5, 2023

Conversation

nickwilliams-zaxiom
Copy link
Contributor

See the detailed explanation for this change in #2119.

@jwillemsen jwillemsen added the needs review Needs to be reviewed label Sep 11, 2023
@mitza-oci mitza-oci linked an issue Sep 28, 2023 that may be closed by this pull request
First paragraphs in documentation for TAO_UIPMC_Protocol_Factory and MIOP_Strategy_Factory are incorrect #2119
Closed
mitza-oci
mitza-oci approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@mitza-oci mitza-oci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't verified all of the these changes against the code, but the explanation in the linked issue was clear and the doc changes are well-formed.

@mitza-oci mitza-oci merged commit 7105510 into DOCGroup:master Oct 5, 2023
41 checks passed
@nickwilliams-zaxiom nickwilliams-zaxiom deleted the multicast_protocol_documentation_fixes branch October 9, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitza-oci mitza-oci mitza-oci approved these changes

Assignees
No one assigned
Labels
needs review Needs to be reviewed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

First paragraphs in documentation for TAO_UIPMC_Protocol_Factory and MIOP_Strategy_Factory are incorrect
3 participants
@nickwilliams-zaxiom @mitza-oci @jwillemsen