Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documents HtmlAttributesAsString usage with SPA tokens #684

Merged

Conversation

valadas
Copy link
Member

@valadas valadas commented Aug 31, 2022

This assumes that dnnsoftware/Dnn.Platform#5242 gets merged first...

Copy link
Contributor

@bdukes bdukes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

content/tutorials/client-resources/index.md Outdated Show resolved Hide resolved
content/tutorials/client-resources/index.md Outdated Show resolved Hide resolved
Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
@valadas
Copy link
Member Author

valadas commented Aug 31, 2022

Oh @bdukes you did the same for CSS right, we should add that to the docs if so

@valadas
Copy link
Member Author

valadas commented Aug 31, 2022

Just added it in the last commit

@bdukes
Copy link
Contributor

bdukes commented Sep 1, 2022

Oh @bdukes you did the same for CSS right, we should add that to the docs if so

Actually I forgot to add changes for the CSS token, I only added the API.

@valadas
Copy link
Member Author

valadas commented Sep 2, 2022

Ok, cool cool, I have re-adjusted the docs accordingly then on this pr.

Copy link
Collaborator

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @valadas - thank you for the contribution! 🎉 🌮

@david-poindexter david-poindexter merged commit bf51ee4 into DNNCommunity:main Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants