Revamped the build process #33
Conversation
This PR moves all files from the `src` folder to the root so it matches what is done with other `core` modules and makes it easier for contributors to find their way around this procject. Cake was having issues myteriously and instead of going down that rabbit hole, I migrated the build process to Nuke which has way less breaking changes and is way easier to understand.
There was a problem hiding this comment.
Looks great - awesome contribution! I just have a few questions to help clean things up a bit.
- It appears there is a rogue
Dnn.Modules.Vendors - Shortcut.lnkfile that needs to be removed. - There is an
Externals/DotNetNuke.WebControls.dll. Is this something that can be removed and referenced viaNuGet? - There is an
artifacts/Dnn.Modules.Vendors_9.1.1_install.zipand my guess is the.gitignoreneeds updating to ignore theartifactsfolder. - The PR has been assigned to the
8.2.0milestone, but the version referenced in the manifest is08.01.01(8.1.1). Perhaps this will be handled via CI, but thought I'd point it out.
|
Ok, 1 and 3 are handled in commits here. For the Externals/... dll I'll remove that in a followup PR when removing Telerik dependency as I'll be better able to check upon dependencies after replaying #32. Some changes are good in #32 but it touched too many unrelated files and will now be out-of-sync to merge anyway. I'll pick what was good from it in next co-coding session to do a new cleaner PR. For versioning, Gitversion will bump path automatically but since we are killing Telerik before the next release I want to make this clear it's a breaking change. Actually I gonna go change that milestone to 9.0.0 instead to make sure to call attention to that. But yeah, GitVersion will only pickup on that change when we have a tag. |
This PR moves all files from the
srcfolder to the root so it matches what is done with othercoremodules and makes it easier for contributors to find their way around this procject.Cake was having issues myteriously and instead of going down that rabbit hole, I migrated the build process to Nuke which has way less breaking changes and is way easier to understand.