Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a wrong project import and removes telerik reference. #79

Merged
merged 1 commit into from
Feb 13, 2021

Conversation

valadas
Copy link
Member

@valadas valadas commented Nov 18, 2020

The module project did not load in visual studio due to the project file trying to load MsBuild.Community.Tasks before a nuget restore happened.

Although this module was already telerik free, there was still a project reference to telerik.web.ui.dll

This does not really affect the build and is just a cleanup for next release.

The module project did not load in visual studio due to the project file trying to load MsBuild.Community.Tasks before a nuget restore happened.

Although this module was already telerik free, there was still a project reference to telerik.web.ui.dll

This does not really affect the build and is just a cleanup for next release.
Copy link
Contributor

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thank you for doing this @valadas 🎉

@david-poindexter
Copy link
Contributor

@SCullman I did not merge this PR because I wasn't quite sure your preferred workflow for releases.

@valadas valadas added this to the 6.5.5 milestone Feb 13, 2021
@valadas valadas merged commit 6feb442 into DNNCommunity:development Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants