PasswordChangeRequired support #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PasswordChangeRequired support Signed-off-by: peter.cy.chen <peter.cy.chen@aewin.com>
This was referenced Jul 31, 2023
Closed
mraineri
reviewed
Aug 1, 2023
mraineri
reviewed
Aug 1, 2023
mraineri
reviewed
Aug 1, 2023
|
Overall this is looking like it's going in the right direction I was considering originally; just a few comments to review first. |
2. ignore "code" and "message" redfish message item 3. if redfish message not provide @Message.ExtendedInfo, use "code" and "message" as @Message.ExtendedInfo Signed-off-by: peter.cy.chen <peter.cy.chen@aewin.com>
PeterKchen2
force-pushed
the
PasswordChangeRequired
branch
from
79ac7eb
to
269c81f
Compare
|
I changed the code according to your suggestion |
mraineri
reviewed
Aug 2, 2023
mraineri
reviewed
Aug 2, 2023
1. remove verify_response function 2. not process @Message.ExtendedInfo's item excet Message and MessageId Signed-off-by: peter.cy.chen <peter.cy.chen@aewin.com>
|
I changed the code according to your suggestion |
Signed-off-by: peter.cy.chen <peter.cy.chen@aewin.com>
|
Any feedback about this change |
|
Looks good to me; I'm going to show it to a few others shortly and we should be good to merge it then |
|
Approved 8/4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PasswordChangeRequired support