Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RESPONSE_IF_READY is not handled correctly in responder #1780

Closed
RohitPatil555 opened this issue Mar 9, 2023 · 1 comment · Fixed by #1810
Closed

RESPONSE_IF_READY is not handled correctly in responder #1780

RohitPatil555 opened this issue Mar 9, 2023 · 1 comment · Fixed by #1810
Assignees
@jyao1
Labels
bug Something isn't working
Milestone
Q2 2023

Comments

@RohitPatil555
Copy link

It observe that libspdm assert get hit as soon as it receive response if ready message.

libspdm/library/spdm_responder_lib/libspdm_rsp_receive_send.c

Line 89 in 66b87ee

LIBSPDM_ASSERT(request_code != SPDM_RESPOND_IF_READY);

@jyao1 jyao1 self-assigned this Mar 13, 2023
@jyao1
Copy link
Member

jyao1 commented Mar 13, 2023

Agree. it is mismatch.

jyao1 added a commit to jyao1/libspdm that referenced this issue Mar 16, 2023
@jyao1
Fix incorrect SPDM_RESPOND_IF_READY
75ccdcf 
Fix DMTF#1780

Signed-off-by: Jiewen Yao <jiewen.yao@intel.com>
@jyao1 jyao1 mentioned this issue Mar 16, 2023
Merged
@steven-bellock steven-bellock added the bug Something isn't working label Mar 24, 2023
@steven-bellock steven-bellock added this to the Q1 2023 milestone Mar 24, 2023
@steven-bellock steven-bellock mentioned this issue Mar 28, 2023
Open
steven-bellock pushed a commit that referenced this issue Mar 28, 2023
@jyao1 @steven-bellock
Fix incorrect SPDM_RESPOND_IF_READY
7a1aa58 
Fix #1780

Signed-off-by: Jiewen Yao <jiewen.yao@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jyao1 jyao1

Labels
bug Something isn't working
Projects
None yet
Milestone
Q2 2023
Development

Successfully merging a pull request may close this issue.

Fix incorrect SPDM_RESPOND_IF_READY jyao1/libspdm
3 participants
@steven-bellock @jyao1 @RohitPatil555