Fix for #3443 - bar chart click function broken in usage dashboard #3444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronskiba
reviewed
Aug 15, 2024
app/javascript/src/usage/index.js
Outdated
| @@ -42,11 +42,12 @@ $(() => { | |||
| const usersData = JSON.parse($('#users_joined').val()); | |||
| if (isObject(usersData)) { | |||
| const chart = createChart('#yearly_users', usersData, '', (event) => { | |||
| const segment = chart.getElementAtEvent(event)[0]; | |||
| const points = chart.getElementsAtEventForMode(event, 'nearest', { intersect: true }, true); | |||
| const segment = points[0]; | |||
| if (!isUndefined(segment)) { | |||
| const target = $('#users_click_target').val(); | |||
| /* eslint-disable no-underscore-dangle, no-restricted-globals */ | |||
There was a problem hiding this comment.
The bar chart click function is now working. :) Given these code changes, I think no-underscore-dangle, can now be removed from eslint-disable throughout the file (can be double-checked by executing yarn run eslint app/javascript/src/usage/index.js).
There was a problem hiding this comment.
Thanks Aaron! I didn't know that. I'll create another commit to remove it now.
benjaminfaure
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3443
Changes proposed in this PR:
getElementAtEventreplaced bygetElementsAtEventForMode