Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for bug in Plan duplication results in original plan identifier b… #3441

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Commits on Jul 29, 2024

  1. Fix for bug in Plan duplication results in original plan identifier b…

    …eing copied.
    
    Change in class method Plan.deep_copy:
      - Firstly, on duplicating the Plan we set the plan identifier to nil and save.
      - Then we fill the identifier variable with the Plan id that was
          regenerated when the duplicate copy was save in the previous.
      - We then persist this change by saving the Plan again.
    John Pinto committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    36e5b7d View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Fix for bug in Plan duplication results in original plan identifier b…

    …eing copied.
    
    Changes (suggested by @aaronskiba):
      - removed an unnecessary line
          plan_copy.identifier = nil
      - cast to string the integer-valued plan id
        plan_copy.identifier = plan_copy.id.to_s
    John Pinto committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    20b5e14 View commit details
    Browse the repository at this point in the history