Skip to content

Commit

Permalink
replace 'safe_email' with 'email' for Faker
Browse files Browse the repository at this point in the history
Prior to this commit, the following deprecation warning was appearing in the terminal:
NOTE: Faker::Internet.safe_email is deprecated; use email instead. It will be removed on or after 2023-10.

More here: faker-ruby/faker#2733
  • Loading branch information
aaronskiba committed Feb 1, 2024
1 parent e0c62da commit de5afd5
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion spec/factories/orgs.rb
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
region { Region.first || create(:region) }
language { Language.default }
is_other { false }
contact_email { Faker::Internet.safe_email }
contact_email { Faker::Internet.email }
contact_name { Faker::Name.name }
managed { true }
trait :institution do
Expand Down
2 changes: 1 addition & 1 deletion spec/factories/users.rb
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
language { Language.default }
firstname { Faker::Name.unique.first_name }
surname { Faker::Name.unique.last_name }
email { Faker::Internet.unique.safe_email }
email { Faker::Internet.unique.email }
password { 'password' }
accept_terms { true }

Expand Down
2 changes: 1 addition & 1 deletion spec/models/plan_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -592,7 +592,7 @@

context 'when org contact_email present' do
before do
org.update!(contact_email: Faker::Internet.safe_email)
org.update!(contact_email: Faker::Internet.email)
end

it 'emails the admins' do
Expand Down

0 comments on commit de5afd5

Please sign in to comment.