-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
judge: pass result
to checkers
#1021
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1021 +/- ##
===========================================
- Coverage 81.24% 53.30% -27.95%
===========================================
Files 140 140
Lines 4789 4784 -5
===========================================
- Hits 3891 2550 -1341
- Misses 898 2234 +1336
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're going to do this, let's just pass the whole result object
Hm.. but keep the rest of the kwargs for backward compatability? |
Yes |
Passing |
max_memory
to checkersresult
to checkers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
4c865b1
to
de7a252
Compare
Seems |
Keep all old arguments to `check` for backward compatibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
No description provided.