-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gymnasium support #1327
Merged
Merged
Add Gymnasium support #1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
1 task
* Fix SAC type hints, improve DQN ones * Fix A2C and TD3 type hints * Fix PPO type hints * Fix on-policy type hints * Fix base class type annotation, do not use defaults * Update version
14 tasks
This was referenced Apr 14, 2023
Just so I know- what's the plan for making a release that includes this PR? |
Alpha release is already on pypi since 15 days, stable release will be in some weeks if everything is fine. |
1 task
This was referenced Jun 7, 2023
AkashKarnatak
added a commit
to AkashKarnatak/FinRL
that referenced
this pull request
Jun 10, 2023
…DLR-RM/stable-baselines3#1327) pull request got merged in `stable-baselines3`. This commit fixes AI4Finance-Foundation#1010
zhumingpassional
pushed a commit
to AI4Finance-Foundation/FinRL
that referenced
this pull request
Jun 15, 2023
* After [this](DLR-RM/stable-baselines3@9c338f9) by `stable-baselines3`, DummyVecEnv.reset() method passes a `seed` argument to its list of envs. Since StockTradingEnv.reset() does not expect any argument it results in an error. This commit fixes #1022. * DummyVecEnv.render() no longer returns the expected state after [this](DLR-RM/stable-baselines3#1327) pull request got merged in `stable-baselines3`. This commit fixes #1010
This was referenced Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Like #780 but with gymnasium as default and compat wrapper on (would close #871 too).
Installation:
Documentation is available here: https://stable-baselines3.readthedocs.io/en/feat-gymnasium-support/
There is an alpha version on pypi:
Some new issues:
Missing:
Related but due to pygame: pygame/pygame#3572
Motivation and Context
Types of changes
closes #840 #871
closes #271
closes #1156
closes #1324
closes #1406
closes #1315
Checklist
make format
(required)make check-codestyle
andmake lint
(required)make pytest
andmake type
both pass. (required)make doc
(required)Note: You can run most of the checks using
make commit-checks
.Note: we are using a maximum length of 127 characters per line