Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0] fix (Core): limit read to TLS payload size #8028

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

chaen
Copy link
Contributor

@chaen chaen commented Feb 4, 2025

2025-02-03 21:04:46 UTC Framework ERROR: Network error while receiving data
Traceback (most recent call last):
  File "/home/chaen/dirac/DIRAC/src/DIRAC/Core/DISET/private/Transports/BaseTransport.py", line 238, in receiveData
    retVal = self._read(pkgSize - readSize, skipReadyCheck=True)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/chaen/dirac/DIRAC/src/DIRAC/Core/DISET/private/Transports/M2SSLTransport.py", line 465, in _read
    read = self.oSocket.read(bufSize)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/chaen/miniforge3/envs/diracprod/lib/python3.11/site-packages/M2Crypto/SSL/Connection.py", line 420, in 
read
    return self._read_bio(size)
           ^^^^^^^^^^^^^^^^^^^^
  File "/home/chaen/miniforge3/envs/diracprod/lib/python3.11/site-packages/M2Crypto/SSL/Connection.py", line 362, in 
_read_bio
    return m2.ssl_read(self.ssl, size, self._timeout)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
OverflowError: in method 'ssl_read', argument 2 of type 'int'

BEGINRELEASENOTES

*Core
FIX: read at most 2^14 bytes at the same time

ENDRELEASENOTES

@DIRACGridBot DIRACGridBot added the alsoTargeting:integration Cherry pick this PR to integration after merge label Feb 4, 2025
@chaen chaen merged commit ce1dc03 into DIRACGrid:rel-v8r0 Feb 4, 2025
26 checks passed
@DIRACGridBot DIRACGridBot added the sweep:done All sweeping actions have been done for this PR label Feb 4, 2025
DIRACGridBot pushed a commit to DIRACGridBot/DIRAC that referenced this pull request Feb 4, 2025
@DIRACGridBot
Copy link

Sweep summary

Sweep ran in https://github.com/DIRACGrid/DIRAC/actions/runs/13133918674

Successful:

  • integration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alsoTargeting:integration Cherry pick this PR to integration after merge sweep:done All sweeping actions have been done for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants