-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[integration] Simplifying Time module #6091
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rupozzi
changed the title
[integration] Simplifying DIRAC.Time module
[integration] Simplifying Time module
May 19, 2022
fstagni
reviewed
May 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments apply to more than 1 file.
src/DIRAC/ConfigurationSystem/scripts/dirac_admin_sort_cs_sites.py
Outdated
Show resolved
Hide resolved
rupozzi
requested review from
chaen,
TaykYoku,
andresailer and
atsareg
as code owners
May 20, 2022 13:19
fstagni
reviewed
May 20, 2022
fstagni
reviewed
May 30, 2022
rupozzi
force-pushed
the
utilstime
branch
3 times, most recently
from
May 31, 2022 16:30
43d9164
to
e64910a
Compare
fstagni
reviewed
May 31, 2022
fstagni
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially solving #2207
BEGINRELEASENOTES
*Core
CHANGE: changed name and simplified repetitive methods of Utilities.TIme
ENDRELEASENOTES