Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Child & Parent logic/review/testing #13

Merged
merged 59 commits into from
Nov 12, 2020
Merged

Conversation

jamesmorgan
Copy link
Contributor

@jamesmorgan jamesmorgan commented Nov 9, 2020

  • Variable and method renames
  • Ensure future bank can mint 1155s
  • Ensure future bank can burn 1155s
  • Ability to topup children tokens
  • Ability to increase balance of children tokens
  • Ensure access controls correctly modelled - admin -> smart contract -> minter
  • Add max children token logic
  • Enforce only Alice can send child tokens to tokens Alice owns
  • GAS Reports
  • Check method alignment to 998 if possible - aligned as close as possible
  • Check contract deployment size - all under 24kb
  • Ensure test coverage is high enough for us eot he satisfied
  • Consistent revert reasons
  • Run contracts through fuzzer/testing tool
  • docs

jamesmorgan and others added 30 commits November 9, 2020 12:59
…igitalax-contracts into child-parent-review-and-docs
…igitalax-contracts into child-parent-review-and-docs
@jamesmorgan jamesmorgan merged commit 8bff482 into main Nov 12, 2020
@jamesmorgan jamesmorgan deleted the child-parent-review-and-docs branch November 12, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants