Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VolInfo #430

Merged
merged 15 commits into from
Mar 11, 2022
Merged

VolInfo #430

merged 15 commits into from
Mar 11, 2022

Conversation

dcoeurjo
Copy link
Member

@dcoeurjo dcoeurjo commented Feb 11, 2022 •
edited
Loading

PR Description

VolInfo simple tool to get info (size and values) from a vol file

Checklist

  • Doxygen documentation of the code completed (classes, methods, types, members...).
  • Main tool doxygen documentation (following existing documentation of DGtalTools documentation.
  • Check if it follows the tools structure described in CONTRIBUTING.md
  • New entry in the ChangeLog.md added.
  • Update the readme with potentially a screenshot of the tools if it applies.
  • No warning raised in Debug cmake mode (otherwise, Travis C.I. will fail).
  • All continuous integration tests pass (Github Actions & appveyor).

@kerautret kerautret self-assigned this Mar 10, 2022
kerautret
kerautret reviewed Mar 11, 2022
View reviewed changes
Copy link
Member

@kerautret kerautret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new tools just some typo and proposition to use GenericReader

volumetric/volInfo.cpp Outdated Show resolved Hide resolved
volumetric/volInfo.cpp Outdated
Positionals:
1 TEXT:FILE REQUIRED Input vol file.

Options:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks duplicated ?

volumetric/volInfo.cpp Outdated Show resolved Hide resolved
volumetric/volInfo.cpp Outdated Show resolved Hide resolved
volumetric/volInfo.cpp Outdated Show resolved Hide resolved
dcoeurjo and others added 6 commits March 11, 2022 16:48
@dcoeurjo @kerautret
Update volumetric/volInfo.cpp
c737901 
Co-authored-by: Bertrand Kerautret <bertrand.kerautret@univ-lyon2.fr>
@dcoeurjo @kerautret
Update volumetric/volInfo.cpp
ae9bee0 
Co-authored-by: Bertrand Kerautret <bertrand.kerautret@univ-lyon2.fr>
@dcoeurjo @kerautret
Update volumetric/volInfo.cpp
7a7bd41 
Co-authored-by: Bertrand Kerautret <bertrand.kerautret@univ-lyon2.fr>
@dcoeurjo @kerautret
Update volumetric/volInfo.cpp
848610d 
Co-authored-by: Bertrand Kerautret <bertrand.kerautret@univ-lyon2.fr>
@dcoeurjo
Update volInfo.cpp
1fda16f
@dcoeurjo
Update volInfo.cpp
cf22b4e
@dcoeurjo
Copy link
Member Author

thx for the feedbacks. Fixed

@kerautret
Copy link
Member

thx for the feedbacks. Fixed

you are welcome, you just forget the duplicate doc first remarks

kerautret
kerautret reviewed Mar 11, 2022
View reviewed changes
volumetric/volInfo.cpp Outdated Show resolved Hide resolved
volumetric/volInfo.cpp Outdated Show resolved Hide resolved
@kerautret
Copy link
Member

@dcoeurjo if you review PR #433 it will fix the CI check ;) and I suggested other small typo that I miss

dcoeurjo and others added 3 commits March 11, 2022 17:17
@dcoeurjo @kerautret
Update volumetric/volInfo.cpp
1c6f739 
Co-authored-by: Bertrand Kerautret <bertrand.kerautret@univ-lyon2.fr>
@dcoeurjo @kerautret
Update volumetric/volInfo.cpp
0a6f470 
Co-authored-by: Bertrand Kerautret <bertrand.kerautret@univ-lyon2.fr>
@dcoeurjo
Merge branch 'master' into volInfo
1dca17a
@dcoeurjo
Copy link
Member Author

👍

@dcoeurjo dcoeurjo merged commit c74c1be into master Mar 11, 2022
@dcoeurjo dcoeurjo deleted the volInfo branch March 11, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerautret kerautret kerautret approved these changes

Assignees

@kerautret kerautret

Labels
Volumetric waiting author feedbacks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcoeurjo @kerautret