-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: CLI11 to replace Boost program option #373
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerautret
added a commit
that referenced
this pull request
May 5, 2020
auto merge (not very important with PR #373 )
Cli11 : convert 2dLocalEstimators.cpp
Youhou !! 🎉🎉🎉 |
thanks @kerautret and @ngophuc for this impressive work |
dcoeurjo
requested changes
Sep 21, 2020
Huge thank :) merging |
dcoeurjo
approved these changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description/instructions (Work In Progress)
Main steps to transform each tool:
1. Removes the boost program options related headers and replace them with CLI1.hpp:
2. Comment in order to remove the option descriptions and parser parts, like for instance here:
3. Apply the CLI11 format with shorter style:
Start with the CLI object:
![Capture d’écran 2020-04-23 à 10 58 37](https://user-images.githubusercontent.com/772865/80080119-6dd8ee80-8551-11ea-97de-40f6580e1a9a.png)
![Capture d’écran 2020-04-23 à 10 50 34](https://user-images.githubusercontent.com/772865/80079276-5baa8080-8550-11ea-983c-131b28824d71.png)
And then add the options:
4. Check the executable with at least basic examples.
5. Update the documentation
6. Push your commit on the current branch or apply a Pull Request on it:
https://github.com/kerautret/DGtalTools/tree/CLI11
Progression:
Transform all tools of convertors:
Transform all tools of estimators:
Transform all tools of generators:
Transform all tools of geometricTransform:
Transform all tools of imageProcessing:
Transform all tools of visualisation
Transform all tools of volumetric:
Checklist
cmake
mode (otherwise, Travis C.I. will fail).