-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add sdp as input for tangentBC #288
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fine for me otherwise
ChangeLog.md
Outdated
@@ -26,7 +26,8 @@ | |||
- *estimators*: | |||
- 2dlocalEstimators: add an option to export the generated contour. | |||
(Bertrand Kerautret, [#285](https://github.com/DGtal-team/DGtalTools/pull/285)) | |||
|
|||
- tangentBC: add anoption to read sdp points as input. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
an option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done thanks
and I have also added the source contour point as output (can be important when using fc) |
Ok thanks. Let's wait for travis. Are you ready for the release BTW ? |
yes I have not done the DGtal doc example move (perhaps time tonight) |
oups I just forget a white space in the output, I pushed it sorry for travis |
fine done merging thanks |
PR Description
tangentBC: add anoption to read sdp points as input.
Checklist
cmake
mode (otherwise, Travis C.I. will fail).