fix colors in 3dSDPViewer #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -428,19 +428,16 @@ int main( int argc, char** argv ) | |||
| } | |||
| if(vm.count("addMesh")) | |||
| { | |||
| DGtal::Color meshColor = DGtal::Color::White; | |||
| if(vm.count("customColorMesh")){ | |||
| bool customColorMesh = vm.count("customColorMesh"); | |||
There was a problem hiding this comment.
Maybe "useCustomColorMesh" ?
There was a problem hiding this comment.
for my part I prefer shorter, but in fact we have the same in other tools I think, perhaps we could change it globaly if needed ;)
There was a problem hiding this comment.
It was just for the boolean in code, not for the option name.
This could be easier to understand for external peoples.
|
Good fix, thanks ! |
|
so merging ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
The mesh display was always displayed in white instead their original colors.
Checklist
cmakemode (otherwise, Travis C.I. will fail).