Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing STB image symbol duplicates #1715

Merged
merged 3 commits into from
Jan 28, 2024
Merged

Fixing STB image symbol duplicates #1715

merged 3 commits into from
Jan 28, 2024

Conversation

dcoeurjo
Copy link
Member

@dcoeurjo dcoeurjo commented Jan 27, 2024 •
edited
Loading

PR Description

Fixes stb image symbol duplicates (#1714) following @nzfeng's suggestions.

Checklist

  • Unit-test of your feature with Catch.
  • Doxygen documentation of the code completed (classes, methods, types, members...)
  • Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug mode.
  • All continuous integration tests pass (Github Actions)

@dcoeurjo dcoeurjo changed the title Fixing STB imge symbol duplicates Fixing STB image symbol duplicates Jan 27, 2024
@dcoeurjo
Copy link
Member Author

@kerautret could you please have a look to this one? It seems to be related to issues you've fixed for DGtalTools.

@dcoeurjo dcoeurjo requested a review from kerautret January 28, 2024 09:33
@kerautret
Copy link
Member

@kerautret could you please have a look to this one? It seems to be related to issues you've fixed for DGtalTools.

Yes thanks I look it, perhaps it could avoid the fix inside the tools ;)

kerautret
kerautret approved these changes Jan 28, 2024
View reviewed changes
Copy link
Member

@kerautret kerautret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, since the tools issue was only on windows, I think that we could merge and I will check if the fix can be remove (else quite non direct to check on CI with multiple branches) ;)

src/DGtal/math/linalg/EigenDecomposition.ih Show resolved Hide resolved
@kerautret kerautret mentioned this pull request Jan 28, 2024
Open
@dcoeurjo
Copy link
Member Author

thx

@dcoeurjo dcoeurjo merged commit 98d790d into master Jan 28, 2024
22 checks passed
@dcoeurjo
Copy link
Member Author

Merging.

@dcoeurjo dcoeurjo deleted the stbSymbols branch January 28, 2024 10:29
@dcoeurjo dcoeurjo mentioned this pull request Jan 28, 2024
Closed
This was referenced Feb 1, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerautret kerautret kerautret approved these changes

Assignees
No one assigned
Labels
ready for review 👍
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcoeurjo @kerautret