Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problems with examples/topology/ctopo-fillContours #1296

Closed
copyme opened this issue Nov 17, 2017 · 2 comments
Closed

Problems with examples/topology/ctopo-fillContours #1296

copyme opened this issue Nov 17, 2017 · 2 comments

Comments

@copyme
Copy link
Member

copyme commented Nov 17, 2017

When I run this code I get:

New Block [Example ctopo-fillContours]
[ERR] Assertion Error - assertion (cIsInside( kp )) failed in Cell DGtal::KhalimskySpaceND<2, int>::uCell(const Point &) const [dim = 2, TInteger = int]: /home/kacper/tmp/DGtal-0.9.3/src/DGtal/topology/KhalimskySpaceND.ih(706)
Aborted (core dumped)
rolanddenis added a commit to rolanddenis/DGtal that referenced this issue Nov 17, 2017
@rolanddenis
Fixing invalid cell coordinates in ctopo-fillContours.cpp
18b1a67 
See DGtal-team#1296. The KhalimskyCell is only used to get his className in order
to define a CustomStyle for the Board2D. The fix replaces the invalid
cell by the lowerCell of the KhalismkySpace.
@rolanddenis
Copy link
Member

The invalid cell is only used to get his className in order to create a CustomStyle. I though I have check all examples when adding these assertions in #1086 but it seems I have missed this one.

PR incoming. Thanks !

@rolanddenis rolanddenis mentioned this issue Nov 17, 2017
Merged
3 tasks
dcoeurjo added a commit that referenced this issue Nov 18, 2017
@dcoeurjo
Merge pull request #1297 from rolanddenis/fix_1296
295b98e 
Fixing #1296 : invalid cell coordinates in ctopo-fillContours.cpp
@rolanddenis
Copy link
Member

Fixed in #1296, closing ...
Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@copyme @rolanddenis